Add mappings for current location and hometown #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facebook API can provide a user's current location and hometown. However, to support this in passport-facebook, we need mappings from the Portable Contacts schema to Facebook's own one. This allows you to now include 'hometown' and 'currentLocation' in the profileFields array.
|
+1 |
rwky
added a commit
to passport-next/passport-facebook
that referenced
this pull request
Jul 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facebook API can provide a user's current location
and hometown. However, to support this in
passport-facebook, we need mappings from
the Portable Contacts schema to Facebook's
own one.
This allows you to now include 'hometown'
and 'currentLocation' in the profileFields
array.