Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--all --grand-total fails for private gems that have dummy packages on public repository #25

Closed
elyalvarado opened this issue Jan 11, 2023 · 1 comment
Closed

--all --grand-total fails for private gems that have dummy packages on public repository #25

elyalvarado opened this issue Jan 11, 2023 · 1 comment

Comments

@elyalvarado
Copy link
Contributor

This is the case for example for the sidekiq-ent gem, which when querying the versions json on rubygems returns an unexisting 0.0.1 version and that causes the program to crash with an stack trace as the following:

/opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/gems/2.7.0/gems/libyear-bundler-0.6.1/lib/libyear_bundler/calculators/version_sequence_delta.rb:8:in `calculate': undefined method `-' for nil:NilClass (NoMethodError)
	from /opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/gems/2.7.0/gems/libyear-bundler-0.6.1/lib/libyear_bundler/models/gem.rb:96:in `version_sequence_delta'
	from /opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/gems/2.7.0/gems/libyear-bundler-0.6.1/lib/libyear_bundler/report.rb:137:in `increment_seq_deltas'
	from /opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/gems/2.7.0/gems/libyear-bundler-0.6.1/lib/libyear_bundler/report.rb:54:in `increment_metrics_summary'
	from /opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/gems/2.7.0/gems/libyear-bundler-0.6.1/lib/libyear_bundler/report.rb:37:in `block in to_h'
	from /opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/gems/2.7.0/gems/libyear-bundler-0.6.1/lib/libyear_bundler/report.rb:37:in `each'
	from /opt/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/gems/2.7.0/gems/libyear-bundler-0.6.1/lib/libyear_bundler/report.rb:37:in `to_h'
...

This issue is very similar to #21
@elyalvarado elyalvarado mentioned this issue Jan 11, 2023
Merged
jaredbeck pushed a commit that referenced this issue Jan 25, 2023
@elyalvarado
Handle private gems inconsistencies as reported in #25 (#26)
18a224a 
* Handle private gems inconsistencies as reported in #25

This PR solves the issue reported in #25

* Add CHANGELOG.md entry for PR #26
@jaredbeck
Copy link
Owner

Looks like this was closed by #26 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredbeck @elyalvarado