Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure complexity in implied_dirs #94

Merged
merged 4 commits into from
Feb 25, 2023

Conversation

jaraco
Copy link
Owner

@jaraco jaraco commented Feb 25, 2023

Fixes python/cpython#102209.

Because this change depends on numpy, it probably can't be ported into CPython, so I've added import_or_skip logic so that test will be skipped in CPython.

@jaraco
Copy link
Owner Author

jaraco commented Feb 25, 2023

It looks like the tests are flaky. Consider this run where big_o determined the most likely complexity to be Linearithmic (O(nlogn)). Time will tell just how flaky it is or what factors might reduce the flakiness.

@jaraco jaraco force-pushed the gh-102209/measure-complexity-implied-dirs branch from f60e5e6 to 6416ac3 Compare February 25, 2023 01:49
@jaraco jaraco force-pushed the gh-102209/measure-complexity-implied-dirs branch from 6416ac3 to a288ab4 Compare February 25, 2023 01:50
@jaraco jaraco force-pushed the gh-102209/measure-complexity-implied-dirs branch from a288ab4 to 54cd2d2 Compare February 25, 2023 01:58
@jaraco jaraco merged commit 63bdf88 into main Feb 25, 2023
@jaraco jaraco deleted the gh-102209/measure-complexity-implied-dirs branch February 25, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_implied_dirs_performance is flaky
1 participant