Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompleteDirs and FastLookup appear as public API #78

Closed
jaraco opened this issue Sep 29, 2021 · 0 comments
Closed

CompleteDirs and FastLookup appear as public API #78

jaraco opened this issue Sep 29, 2021 · 0 comments

Comments

@jaraco
Copy link
Owner

jaraco commented Sep 29, 2021

It came to my attention that the CompleteDirs and FastLookup classes appear as the public API. Because they're not underscore-prefixed or excluded from __all__, they appear in import * and in the docs:

image

These classes are internal implementation details and should be excluded from the public API.

These classes do not appear in the CPython zipfile docs and are excluded from __all__ in CPython.
@jaraco jaraco closed this as completed in 6591fa7 Sep 29, 2021
halstead pushed a commit to openembedded/openembedded-core that referenced this issue Oct 13, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
5164304 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
splitice pushed a commit to HalleyAssist/poky that referenced this issue Oct 13, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
76df29d 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 5164304579b5bbd02821c3b851c86a9a263899e2)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
splitice pushed a commit to HalleyAssist/poky that referenced this issue Oct 13, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
37a7858 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 5164304579b5bbd02821c3b851c86a9a263899e2)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
kraj pushed a commit to YoeDistro/poky-old that referenced this issue Oct 13, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
d051df3 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 5164304579b5bbd02821c3b851c86a9a263899e2)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
armcc pushed a commit to lgirdk/poky that referenced this issue Oct 13, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
f89ea77 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 5164304579b5bbd02821c3b851c86a9a263899e2)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
splitice pushed a commit to HalleyAssist/poky that referenced this issue Oct 14, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
fe02bde 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 5164304579b5bbd02821c3b851c86a9a263899e2)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
splitice pushed a commit to HalleyAssist/poky that referenced this issue Oct 14, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
ed758e8 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 5164304579b5bbd02821c3b851c86a9a263899e2)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
splitice pushed a commit to HalleyAssist/poky that referenced this issue Oct 14, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
ea579ee 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 70533dd6d0a14494720bac4521095ddd4e1bb53b)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this issue Oct 14, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
70533dd 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this issue Oct 14, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
682db79 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
seambot pushed a commit to seamapi/poky that referenced this issue Oct 14, 2021
@moto-timo @rpurdie
python3-zipp: upgrade 3.5.0 -> 3.6.0
e3c677a 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 682db790542212e921eb6d874c2915ac815ee9bd)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@moto-timo @rpurdie
src/poky:python3-zipp: upgrade 3.5.0 -> 3.6.0
bcc197a 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 682db790542212e921eb6d874c2915ac815ee9bd)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@moto-timo @rpurdie
src/poky:python3-zipp: upgrade 3.5.0 -> 3.6.0
97cbcea 
v3.6.0
  #78: Only Path is exposed in the public API.

v3.5.1
  #77: Remove news file intended only for CPython.

References:
  jaraco/zipp#78
  jaraco/zipp#77

(From OE-Core rev: 682db790542212e921eb6d874c2915ac815ee9bd)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco