Automerge does not block on successful tests, isn't useful #49

jaraco · 2021-04-26T00:36:16Z

In pascalgn/automerge-action#137, I reported an issue and learned that the automerge functionality only works on repositories that enable protected branches. This limitation makes the functionality no different than clicking 'merge'. That makes this functionality impractical to apply to repositories generally. Each repo that wishes to employ it needs to do so with knowledge about the constraints and repo-specific factors. Therefore, I propose to remove it.

jaraco · 2021-04-30T12:59:08Z

Also, Github now offers the feature natively.

…on 56.2.0 Carlton Gibson (2): Fixed quickstart packaging resources hyperlink. Corrected indent in setup.cfg example. Hugo van Kemenade (1): Fix version Jason R. Coombs (6): Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Remove hard-coded indexes of metadata lines. Ref #2641. Add workaround for #2666. Bump version: 56.1.0 → 56.2.0 Marc Mueller (2): Add escaping to license field Always use latest mv version for PKG-INFO Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…sion 5.3.1 Jason R. Coombs (15): Exclude dist from discovered packages. Fixes jaraco/skeleton#46. It's no longer necessary to filter this warning and it's not a warning anymore. Bump minimum pytest Require twine 3 with keyring unconditionally required. Add comments indicating why the exclusions are present Exclude mypy on Python 3.10 as workaround for python/typed_ast#156. Bump minimums on pytest-checkdocs and pytest-enabler as found on Setuptools. Also deny black on Python 3.10 as workaround for python/typed_ast#156. Add leading */ to coverage.run.omit. Workaround for pytest-dev/pytest-cov#456. Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Update changelog. Fix badge Edit for consistency. KOLANICH (1): Added an .editorconfig. Pull request jaraco/skeleton#43. Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…version 1.0.4 to version 1.1.0 Jason R. Coombs (9): Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Add note about possiblility of vendoring. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Add compatibility for mutability and access by index as introduced in importlib_metadata 4.4. Restore Python 2.7 compatibility Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

….1.1 Brian Rutledge (1): Use shutil for rmtree Jason R. Coombs (22): It's no longer necessary to filter this warning and it's not a warning anymore. Bump minimum pytest Require twine 3 with keyring unconditionally required. Add comments indicating why the exclusions are present Exclude mypy on Python 3.10 as workaround for python/typed_ast#156. Bump minimums on pytest-checkdocs and pytest-enabler as found on Setuptools. Also deny black on Python 3.10 as workaround for python/typed_ast#156. Add leading */ to coverage.run.omit. Workaround for pytest-dev/pytest-cov#456. Implement skip so it's always covered Add example using Scheduler. Fixes #15. Add headings for easier reading and anchors. Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Add types for dependencies. Fixes test failures. Add support for more formats in parse_timedelta. Add support for other shorthand indications of time. Honor nanoseconds at the microsecond resolution. Fixes #17. Fix issues when digits are picked up by the unit. Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

Brian Rutledge (1): Use shutil for rmtree Jason R. Coombs (14): Require twine 3 with keyring unconditionally required. Add comments indicating why the exclusions are present Exclude mypy on Python 3.10 as workaround for python/typed_ast#156. Bump minimums on pytest-checkdocs and pytest-enabler as found on Setuptools. Also deny black on Python 3.10 as workaround for python/typed_ast#156. Add leading */ to coverage.run.omit. Workaround for pytest-dev/pytest-cov#456. Update readme to declare that it's the official backport. Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Update changelog. Miguel Brito (1): bpo-44095: Add suffix, stem and suffixes to zipfile.Path (GH-26129) Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…23.1.0 Brian Rutledge (1): Use shutil for rmtree Dmitry Shachnev (1): Fix markup error in CHANGES.rst Jason R. Coombs (14): Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Rely on setuptools 56 and drop the explicit mention of the license file in favor of simple discovery. Remove workaround for python/typed_ast#156. Use line continuations to indicate which exclusions are for which workarounds. Remove blacken docs as it cannot honor Python's default repr. Ref adamchainz/blacken-docs#62. Add another code ⚫ Fade to black. 👹 Feed the hobgoblins (delint). Update changelog. Spencer Michaels (1): Update MacOS keychain APIs. Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…o version 3.4.0 Brian Rutledge (1): Use shutil for rmtree Jason R. Coombs (11): Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Rely on setuptools 56 and drop the explicit mention of the license file in favor of simple discovery. Remove workaround for python/typed_ast#156. Use line continuations to indicate which exclusions are for which workarounds. Remove blacken docs as it cannot honor Python's default repr. Ref adamchainz/blacken-docs#62. Add WeightedLookup Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…on 3.5.1 Brian Rutledge (1): Use shutil for rmtree Hugo (1): Fix AppVeyor typo Hugo van Kemenade (2): Spelling and capitalisation (#8) Link badge to PyPI rather than static image Jason R. Coombs (74): Python 3 only Cover Python 3.8 in Windows tests Update black in pre-commit and add blacken-docs. Test and release using Azure Pipelines Correct guidance on project creation. Rely on setuptools_scm 3.4 and setuptools 42. Now setup.py is optional. Remove setuptools from test environment. Finish dropping support for Python 2 (I hope). Normalize whitespace Revert "setup.cfg: let python-tag mirror python_requires" Update to bionic for Travis. Correct comment about IPv6 workaround. Suppress warnings in pytest-flake8, pytest-black, and pytest-checkdocs. Prefer pytest-black to pytest-black-multipy Test against Windows and Mac Define a default pool_vm_image Remove tox-venv and tox-pip-version. Tox-venv is discouraged (tox-dev/tox-venv#48 (comment)) and tox-pip-version was only there to support tox-venv. venv is dead; long live virtualenv. Remove more references to tox-venv Add workaround for warning emitted when junitxml is used. Ref pytest-dev/pytest#6178. Include mypy for type checking during tests. Ensure virtualenv is upgraded when installing tox. Fixes jaraco/path#188. Run tests on prereleases of Python on Windows. Fixes jaraco/skeleton#17. Add workaround for python/mypy#8627. Fixes jaraco/skeleton#18. Add 'refresh.svg' demonstrating an example of refreshing a project with the latest skeleton. Ref #7. Move workaround for python/mypy#8627 to tox.ini, as adding it to setup.cfg prevents releases to PyPI. Fixes jaraco/skeleton#19. Remove workaround for python/mypy#8627. Ref jaraco/skeleton#18. Create Github releases when releasing the package. Fixes jaraco/skeleton#23. Moved refresh.svg to another branch. Reference the animation from the docs. Ref jaraco/skeleton#7. Add the env var mapping too. Disable pytest-black and pytest-mypy on PyPy. Fixes jaraco/skeleton#22. Ref pytest-dev/pytest#7675. Bump black and blacken-docs to latest stable versions. Use enabled plugin configuration to enable mypy and black when the plugin is present. Ref jaraco/skeleton#22. Also enable flake8 and cov when the plugins are present. Add workflows for running tests. Ref jaraco/skeleton#24. Cut releases from Github Actions instead of Azure Pipelines. Ref jaraco/skeleton#24. Refresh docs to prefer Github Actions to Azure Pipelines. Ref jaraco/skeleton#24. Use RTD v2 config 🧎‍♀️ Genuflect to the types. Remove compatibility code. Update changelog. Test on Python 3.9. Skip 3.7 to avoid creating too many builds. Release on 3.9. Drop tests on Travis, Appveyor, and Azure Pipelines. use add-github-secrets, which infers the secrets needed from the github workflow. Use inline flags with local scope. Honor TOX_WORK_DIR if set. Workaround for tox-dev/tox#20. Collapse skeleton history from archive/2020-12 Update skeleton description to describe the periodic collapse. Fixes #27. Enable automerge Add trim methods to WordSet 🧎‍♀️ Genuflect to the types. Automatically inject project name in docs heading. pre-commit autoupdate Rename 'Automated Tests' to simply 'tests' Add note about automatic merging of PRs and the requirements and limitations. Prefer pytest-enabler to jaraco.test Enable complexity limit. Fixes jaraco/skeleton#34. Add support for namespace packages. Closes jaraco/skeleton#40. Normalize indentation Rely on PEP 420 for namespace package Update changelog. Exclude dist from discovered packages. Fixes jaraco/skeleton#46. It's no longer necessary to filter this warning and it's not a warning anymore. Bump minimum pytest Require twine 3 with keyring unconditionally required. Add comments indicating why the exclusions are present Exclude mypy on Python 3.10 as workaround for python/typed_ast#156. Bump minimums on pytest-checkdocs and pytest-enabler as found on Setuptools. Also deny black on Python 3.10 as workaround for python/typed_ast#156. Add leading */ to coverage.run.omit. Workaround for pytest-dev/pytest-cov#456. Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Fix syntax for in_. Closes #5. KOLANICH (1): Added an .editorconfig. Pull request jaraco/skeleton#43. Sviatoslav Sydorenko (4): Replace pep517.build with build (#37) Use license_files instead of license_file in meta (#35) Use `extend-ignore` in flake8 config (#33) Make sphinx fail on any warnings (#36) Vincent Fazio (1): setup.cfg: let python-tag mirror python_requires johnthagen (1): Line wrap LICENSE file layday (1): Require toml extra for setuptools_scm (#12)

….0.0 Alan Fregtman (1): .editorconfig: Set max_line_length to 88 for Python files. Brian Rutledge (1): Use shutil for rmtree Jason R. Coombs (25): Exclude dist from discovered packages. Fixes jaraco/skeleton#46. It's no longer necessary to filter this warning and it's not a warning anymore. Bump minimum pytest Require twine 3 with keyring unconditionally required. Add comments indicating why the exclusions are present Exclude mypy on Python 3.10 as workaround for python/typed_ast#156. Bump minimums on pytest-checkdocs and pytest-enabler as found on Setuptools. Also deny black on Python 3.10 as workaround for python/typed_ast#156. Add leading */ to coverage.run.omit. Workaround for pytest-dev/pytest-cov#456. Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Rely on setuptools 56 and drop the explicit mention of the license file in favor of simple discovery. Remove workaround for python/typed_ast#156. Use line continuations to indicate which exclusions are for which workarounds. Remove blacken docs as it cannot honor Python's default repr. Ref adamchainz/blacken-docs#62. Add intersphinx mappings for Python to prevent spurious nitpicky failures. Fixes jaraco/skeleton#51. Test on Python 3.10 (final). Rely on pytest 6 and drop workaround for pytest-dev/pytest#6178. Fix syntax warning in docs. Update changelog. Remove legacy aliases. KOLANICH (1): Added an .editorconfig. Pull request jaraco/skeleton#43. Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…version 1.0.4 to version 1.1.0 Jason R. Coombs (9): Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Add note about possiblility of vendoring. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Add compatibility for mutability and access by index as introduced in importlib_metadata 4.4. Restore Python 2.7 compatibility Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…version 3.4.0 Alan Fregtman (1): .editorconfig: Set max_line_length to 88 for Python files. Brian Rutledge (1): Use shutil for rmtree Jason R. Coombs (17): Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Rely on setuptools 56 and drop the explicit mention of the license file in favor of simple discovery. Remove workaround for python/typed_ast#156. Use line continuations to indicate which exclusions are for which workarounds. Rewrite doc for clarity. Extend doctest Remove blacken docs as it cannot honor Python's default repr. Ref adamchainz/blacken-docs#62. Add intersphinx mappings for Python to prevent spurious nitpicky failures. Fixes jaraco/skeleton#51. Test on Python 3.10 (final). Rely on pytest 6 and drop workaround for pytest-dev/pytest#6178. Remove wheel from build requirements. It's implied for wheel builds. Ref pypa/setuptools#1498. Use functools.wraps to pass through docstrings in apply. Sviatoslav Sydorenko (1): Make sphinx fail on any warnings (#36)

…to version 3.2.2 Alan Fregtman (1): .editorconfig: Set max_line_length to 88 for Python files. Anderson Bravalheri (2): Ignore flake8/black warnings with pytest 7.0.1 (jaraco/skeleton#58) Update Github actions to v3 (#62) Brian Rutledge (1): Use shutil for rmtree Hugo van Kemenade (1): Update base URL for PEPs (#61) Jason R. Coombs (52): Add Tidelift template Rely on alabaster theme to support sidebar rendering. Use nicer, simpler phrasing Add support for automatic publishing of release notes Use technique for environment passing matching that found in jaraco/skeleton Move Tidelift token into Travis configuration Update badge URL Add funding reference to project List sidebars to avoid errors looking for template 't' Rebrand to 'For Enterprise' Add a 'For Enterprise' section to the README Include token passthrough for azure pipelines publish stage. Move Tidelift release note publishing to Github Actions. It's no longer necessary to filter this warning and it's not a warning anymore. Bump minimum pytest Require twine 3 with keyring unconditionally required. Add comments indicating why the exclusions are present Exclude mypy on Python 3.10 as workaround for python/typed_ast#156. Bump minimums on pytest-checkdocs and pytest-enabler as found on Setuptools. Also deny black on Python 3.10 as workaround for python/typed_ast#156. Add leading */ to coverage.run.omit. Workaround for pytest-dev/pytest-cov#456. Tidelift no longer requires or expects publishing release notes. Remove Tidelift from main.yml, no longer needed Remove automerge. Fixes jaraco/skeleton#49. Enable dependabot (#50) Replace md file with badge linking to documentation site. Fixes jaraco/skeleton#47. Test on Python 3.10 Remove setup_requires, obviated by build-requires in pyproject.toml. Suppress deprecation warnings in flake8 and packaging.tags. Ref pypa/packaging#433. Rely on setuptools 56 and drop the explicit mention of the license file in favor of simple discovery. Remove workaround for python/typed_ast#156. Use line continuations to indicate which exclusions are for which workarounds. Implement tidelift banner using a Sphinx directive implemented by jaraco.tidelift. Remove blacken docs as it cannot honor Python's default repr. Ref adamchainz/blacken-docs#62. Add intersphinx mappings for Python to prevent spurious nitpicky failures. Fixes jaraco/skeleton#51. Test on Python 3.10 (final). Rely on pytest 6 and drop workaround for pytest-dev/pytest#6178. Remove wheel from build requirements. It's implied for wheel builds. Ref pypa/setuptools#1498. Require Python 3.7 or later. Remove filtered warnings, addressed upstream. Update badge year Remove setup.py, no longer needed. Add exclusions for pytest 7 deprecations in plugins. Fixes jaraco/skeleton#57. Use the parent category PytestDeprecationWarning, which is available on older pytest versions. Fixes jaraco/skeleton#57. Bump pytest-mypy and remove workaround for realpython/pytest-mypy#131. Require jaraco.packaging 9 adding compatibility for projects with no setup.py file. Ran pre-commit autoupdate Add Python 3.11 into the matrix using workaround from actions/setup-python#213. Drop 3.9 from matrix for efficiency. Prefer spaces for rst. Fixes jaraco/skeleton#64. Honor PEP 518 with pytest-enabler. Ran pre-commit autoupdate Update changelog. KOLANICH (1): Added an .editorconfig. Pull request jaraco/skeleton#43. Sviatoslav Sydorenko (2): Make sphinx fail on any warnings (#36) Inject check job into CI workflow as ultimate flag (#55) wim glenn (1): exclude build env from cov reporting (#60)

jaraco closed this as completed in 6e2d0ba Apr 26, 2021

jaraco mentioned this issue Sep 3, 2022

Simplify Chinese New Year shift workalendar/workalendar#718

Closed

jaraco added a commit to jaraco/jaraco.vcs that referenced this issue Jun 20, 2023

Remove automerge. Fixes jaraco/skeleton#49.

8a52bc0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automerge does not block on successful tests, isn't useful #49

Automerge does not block on successful tests, isn't useful #49

jaraco commented Apr 26, 2021

jaraco commented Apr 30, 2021

Automerge does not block on successful tests, isn't useful #49

Automerge does not block on successful tests, isn't useful #49

Comments

jaraco commented Apr 26, 2021

jaraco commented Apr 30, 2021