Skip to content

Commit

Permalink
Remove wheel from build requirements. It's implied for wheel builds. …
Browse files Browse the repository at this point in the history 
…Ref pypa/setuptools#1498.
  • Loading branch information
@jaraco
jaraco committed Oct 22, 2021
1 parent 5823e9c commit aae281a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools>=56", "wheel", "setuptools_scm[toml]>=3.4.1"]

This comment has been minimized.

Sign in to view

Copy link
@gaborbernat

gaborbernat Oct 22, 2021

And by implied you mean that requires for wheel build will pull it in?

This comment has been minimized.

Sign in to view

Copy link
@jaraco

jaraco Oct 22, 2021

Author Owner

Let me test it...

This comment has been minimized.

Sign in to view

Copy link
@jaraco

jaraco Oct 22, 2021

Author Owner

As I understand it, it's implied by https://github.com/pypa/setuptools/blob/fee9d17d2a9113dbdc4bcfeca8b040af75bcf2f9/setuptools/build_meta.py#L155.

And I confirmed, it works as expected:

keyring main $ cat pyproject.toml
[build-system]
requires = ["setuptools>=56", "setuptools_scm[toml]>=3.4.1"]
build-backend = "setuptools.build_meta"

[tool.black]
skip-string-normalization = true

[tool.setuptools_scm]

[pytest.enabler.black]
addopts = "--black"

[pytest.enabler.mypy]
addopts = "--mypy"

[pytest.enabler.flake8]
addopts = "--flake8"

[pytest.enabler.cov]
addopts = "--cov"
keyring main $ pyproject-build -s -v .
usage: pyproject-build [-h] [--version] [--sdist] [--wheel] [--outdir OUTDIR] [--skip-dependency-check] [--no-isolation] [--config-setting CONFIG_SETTING] [srcdir]
pyproject-build: error: unrecognized arguments: -v
keyring main $ pyproject-build -s .
Found existing installation: setuptools 57.4.0
Uninstalling setuptools-57.4.0:
  Successfully uninstalled setuptools-57.4.0
Collecting setuptools_scm[toml]>=3.4.1
  Using cached setuptools_scm-6.3.2-py3-none-any.whl (33 kB)
Collecting setuptools>=56
  Using cached setuptools-58.2.0-py3-none-any.whl (946 kB)
Collecting packaging>=20.0
  Using cached packaging-21.0-py3-none-any.whl (40 kB)
Collecting tomli>=1.0.0
  Using cached tomli-1.2.1-py3-none-any.whl (11 kB)
Collecting pyparsing>=2.0.2
  Using cached pyparsing-2.4.7-py2.py3-none-any.whl (67 kB)
Installing collected packages: pyparsing, tomli, setuptools, packaging, setuptools-scm
Successfully installed packaging-21.0 pyparsing-2.4.7 setuptools-58.2.0 setuptools-scm-6.3.2 tomli-1.2.1
WARNING: You are using pip version 21.2.3; however, version 21.3.1 is available.
You should consider upgrading via the '/private/var/folders/c6/v7hnmq453xb6p2dbz1gqc6rr0000gn/T/build-env-qoinj9hf/bin/python -m pip install --upgrade pip' command.
running egg_info
creating keyring.egg-info
writing keyring.egg-info/PKG-INFO
writing dependency_links to keyring.egg-info/dependency_links.txt
writing entry points to keyring.egg-info/entry_points.txt
writing requirements to keyring.egg-info/requires.txt
writing top-level names to keyring.egg-info/top_level.txt
writing manifest file 'keyring.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'keyring.egg-info/SOURCES.txt'
running sdist
running egg_info
writing keyring.egg-info/PKG-INFO
writing dependency_links to keyring.egg-info/dependency_links.txt
writing entry points to keyring.egg-info/entry_points.txt
writing requirements to keyring.egg-info/requires.txt
writing top-level names to keyring.egg-info/top_level.txt
adding license file 'LICENSE'
writing manifest file 'keyring.egg-info/SOURCES.txt'
running check
creating keyring-23.2.2.dev7+g0ade53b
creating keyring-23.2.2.dev7+g0ade53b/.github
creating keyring-23.2.2.dev7+g0ade53b/.github/ISSUE_TEMPLATE
creating keyring-23.2.2.dev7+g0ade53b/.github/workflows
creating keyring-23.2.2.dev7+g0ade53b/docs
creating keyring-23.2.2.dev7+g0ade53b/keyring
creating keyring-23.2.2.dev7+g0ade53b/keyring.egg-info
creating keyring-23.2.2.dev7+g0ade53b/keyring/backends
creating keyring-23.2.2.dev7+g0ade53b/keyring/backends/macOS
creating keyring-23.2.2.dev7+g0ade53b/keyring/testing
creating keyring-23.2.2.dev7+g0ade53b/keyring/util
creating keyring-23.2.2.dev7+g0ade53b/tests
creating keyring-23.2.2.dev7+g0ade53b/tests/backends
copying files to keyring-23.2.2.dev7+g0ade53b...
copying .coveragerc -> keyring-23.2.2.dev7+g0ade53b
copying .editorconfig -> keyring-23.2.2.dev7+g0ade53b
copying .flake8 -> keyring-23.2.2.dev7+g0ade53b
copying .gitignore -> keyring-23.2.2.dev7+g0ade53b
copying .pre-commit-config.yaml -> keyring-23.2.2.dev7+g0ade53b
copying .readthedocs.yml -> keyring-23.2.2.dev7+g0ade53b
copying .travis-macos -> keyring-23.2.2.dev7+g0ade53b
copying CHANGES.rst -> keyring-23.2.2.dev7+g0ade53b
copying Dockerfile -> keyring-23.2.2.dev7+g0ade53b
copying LICENSE -> keyring-23.2.2.dev7+g0ade53b
copying README.rst -> keyring-23.2.2.dev7+g0ade53b
copying conftest.py -> keyring-23.2.2.dev7+g0ade53b
copying hook-keyring.backend.py -> keyring-23.2.2.dev7+g0ade53b
copying mypy.ini -> keyring-23.2.2.dev7+g0ade53b
copying pyproject.toml -> keyring-23.2.2.dev7+g0ade53b
copying pytest.ini -> keyring-23.2.2.dev7+g0ade53b
copying setup.cfg -> keyring-23.2.2.dev7+g0ade53b
copying setup.py -> keyring-23.2.2.dev7+g0ade53b
copying tox.ini -> keyring-23.2.2.dev7+g0ade53b
copying .github/FUNDING.yml -> keyring-23.2.2.dev7+g0ade53b/.github
copying .github/dependabot.yml -> keyring-23.2.2.dev7+g0ade53b/.github
copying .github/ISSUE_TEMPLATE/bug_report.md -> keyring-23.2.2.dev7+g0ade53b/.github/ISSUE_TEMPLATE
copying .github/workflows/main.yml -> keyring-23.2.2.dev7+g0ade53b/.github/workflows
copying docs/conf.py -> keyring-23.2.2.dev7+g0ade53b/docs
copying docs/history.rst -> keyring-23.2.2.dev7+g0ade53b/docs
copying docs/index.rst -> keyring-23.2.2.dev7+g0ade53b/docs
copying docs/troubleshooting config.md -> keyring-23.2.2.dev7+g0ade53b/docs
copying keyring/__init__.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/__main__.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/backend.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/cli.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/core.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/credentials.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/devpi_client.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/errors.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/http.py -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring/py.typed -> keyring-23.2.2.dev7+g0ade53b/keyring
copying keyring.egg-info/PKG-INFO -> keyring-23.2.2.dev7+g0ade53b/keyring.egg-info
copying keyring.egg-info/SOURCES.txt -> keyring-23.2.2.dev7+g0ade53b/keyring.egg-info
copying keyring.egg-info/dependency_links.txt -> keyring-23.2.2.dev7+g0ade53b/keyring.egg-info
copying keyring.egg-info/entry_points.txt -> keyring-23.2.2.dev7+g0ade53b/keyring.egg-info
copying keyring.egg-info/requires.txt -> keyring-23.2.2.dev7+g0ade53b/keyring.egg-info
copying keyring.egg-info/top_level.txt -> keyring-23.2.2.dev7+g0ade53b/keyring.egg-info
copying keyring/backends/OS_X.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/SecretService.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/Windows.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/__init__.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/chainer.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/fail.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/kwallet.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/libsecret.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/null.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends
copying keyring/backends/macOS/__init__.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends/macOS
copying keyring/backends/macOS/api.py -> keyring-23.2.2.dev7+g0ade53b/keyring/backends/macOS
copying keyring/testing/__init__.py -> keyring-23.2.2.dev7+g0ade53b/keyring/testing
copying keyring/testing/backend.py -> keyring-23.2.2.dev7+g0ade53b/keyring/testing
copying keyring/testing/util.py -> keyring-23.2.2.dev7+g0ade53b/keyring/testing
copying keyring/util/__init__.py -> keyring-23.2.2.dev7+g0ade53b/keyring/util
copying keyring/util/platform_.py -> keyring-23.2.2.dev7+g0ade53b/keyring/util
copying keyring/util/properties.py -> keyring-23.2.2.dev7+g0ade53b/keyring/util
copying tests/test_core.py -> keyring-23.2.2.dev7+g0ade53b/tests
copying tests/test_errors.py -> keyring-23.2.2.dev7+g0ade53b/tests
copying tests/test_integration.py -> keyring-23.2.2.dev7+g0ade53b/tests
copying tests/test_multiprocess.py -> keyring-23.2.2.dev7+g0ade53b/tests
copying tests/test_packaging.py -> keyring-23.2.2.dev7+g0ade53b/tests
copying tests/backends/test_SecretService.py -> keyring-23.2.2.dev7+g0ade53b/tests/backends
copying tests/backends/test_Windows.py -> keyring-23.2.2.dev7+g0ade53b/tests/backends
copying tests/backends/test_chainer.py -> keyring-23.2.2.dev7+g0ade53b/tests/backends
copying tests/backends/test_kwallet.py -> keyring-23.2.2.dev7+g0ade53b/tests/backends
copying tests/backends/test_libsecret.py -> keyring-23.2.2.dev7+g0ade53b/tests/backends
copying tests/backends/test_macOS.py -> keyring-23.2.2.dev7+g0ade53b/tests/backends
Writing keyring-23.2.2.dev7+g0ade53b/setup.cfg
Creating tar archive
removing 'keyring-23.2.2.dev7+g0ade53b' (and everything under it)
keyring main $ pyproject-build -w .
Found existing installation: setuptools 57.4.0
Uninstalling setuptools-57.4.0:
  Successfully uninstalled setuptools-57.4.0
Collecting setuptools_scm[toml]>=3.4.1
  Using cached setuptools_scm-6.3.2-py3-none-any.whl (33 kB)
Collecting setuptools>=56
  Using cached setuptools-58.2.0-py3-none-any.whl (946 kB)
Collecting tomli>=1.0.0
  Using cached tomli-1.2.1-py3-none-any.whl (11 kB)
Collecting packaging>=20.0
  Using cached packaging-21.0-py3-none-any.whl (40 kB)
Collecting pyparsing>=2.0.2
  Using cached pyparsing-2.4.7-py2.py3-none-any.whl (67 kB)
Installing collected packages: pyparsing, tomli, setuptools, packaging, setuptools-scm
Successfully installed packaging-21.0 pyparsing-2.4.7 setuptools-58.2.0 setuptools-scm-6.3.2 tomli-1.2.1
WARNING: You are using pip version 21.2.3; however, version 21.3.1 is available.
You should consider upgrading via the '/private/var/folders/c6/v7hnmq453xb6p2dbz1gqc6rr0000gn/T/build-env-p6j42ab_/bin/python -m pip install --upgrade pip' command.
running egg_info
writing keyring.egg-info/PKG-INFO
writing dependency_links to keyring.egg-info/dependency_links.txt
writing entry points to keyring.egg-info/entry_points.txt
writing requirements to keyring.egg-info/requires.txt
writing top-level names to keyring.egg-info/top_level.txt
adding license file 'LICENSE'
writing manifest file 'keyring.egg-info/SOURCES.txt'
Collecting wheel
  Using cached wheel-0.37.0-py2.py3-none-any.whl (35 kB)
Installing collected packages: wheel
Successfully installed wheel-0.37.0
WARNING: You are using pip version 21.2.3; however, version 21.3.1 is available.
You should consider upgrading via the '/private/var/folders/c6/v7hnmq453xb6p2dbz1gqc6rr0000gn/T/build-env-p6j42ab_/bin/python -m pip install --upgrade pip' command.
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/keyring
copying keyring/backend.py -> build/lib/keyring
copying keyring/credentials.py -> build/lib/keyring
copying keyring/__init__.py -> build/lib/keyring
copying keyring/core.py -> build/lib/keyring
copying keyring/cli.py -> build/lib/keyring
copying keyring/http.py -> build/lib/keyring
copying keyring/errors.py -> build/lib/keyring
copying keyring/devpi_client.py -> build/lib/keyring
copying keyring/__main__.py -> build/lib/keyring
creating build/lib/keyring/util
copying keyring/util/properties.py -> build/lib/keyring/util
copying keyring/util/__init__.py -> build/lib/keyring/util
copying keyring/util/platform_.py -> build/lib/keyring/util
creating build/lib/keyring/backends
copying keyring/backends/null.py -> build/lib/keyring/backends
copying keyring/backends/kwallet.py -> build/lib/keyring/backends
copying keyring/backends/__init__.py -> build/lib/keyring/backends
copying keyring/backends/fail.py -> build/lib/keyring/backends
copying keyring/backends/OS_X.py -> build/lib/keyring/backends
copying keyring/backends/SecretService.py -> build/lib/keyring/backends
copying keyring/backends/Windows.py -> build/lib/keyring/backends
copying keyring/backends/libsecret.py -> build/lib/keyring/backends
copying keyring/backends/chainer.py -> build/lib/keyring/backends
creating build/lib/keyring/testing
copying keyring/testing/backend.py -> build/lib/keyring/testing
copying keyring/testing/util.py -> build/lib/keyring/testing
copying keyring/testing/__init__.py -> build/lib/keyring/testing
creating build/lib/keyring/backends/macOS
copying keyring/backends/macOS/__init__.py -> build/lib/keyring/backends/macOS
copying keyring/backends/macOS/api.py -> build/lib/keyring/backends/macOS
running egg_info
writing keyring.egg-info/PKG-INFO
writing dependency_links to keyring.egg-info/dependency_links.txt
writing entry points to keyring.egg-info/entry_points.txt
writing requirements to keyring.egg-info/requires.txt
writing top-level names to keyring.egg-info/top_level.txt
adding license file 'LICENSE'
writing manifest file 'keyring.egg-info/SOURCES.txt'
copying keyring/py.typed -> build/lib/keyring
installing to build/bdist.macosx-10.9-universal2/wheel
running install
running install_lib
creating build/bdist.macosx-10.9-universal2
creating build/bdist.macosx-10.9-universal2/wheel
creating build/bdist.macosx-10.9-universal2/wheel/keyring
copying build/lib/keyring/backend.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
creating build/bdist.macosx-10.9-universal2/wheel/keyring/util
copying build/lib/keyring/util/properties.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/util
copying build/lib/keyring/util/__init__.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/util
copying build/lib/keyring/util/platform_.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/util
copying build/lib/keyring/credentials.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
creating build/bdist.macosx-10.9-universal2/wheel/keyring/backends
creating build/bdist.macosx-10.9-universal2/wheel/keyring/backends/macOS
copying build/lib/keyring/backends/macOS/__init__.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends/macOS
copying build/lib/keyring/backends/macOS/api.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends/macOS
copying build/lib/keyring/backends/null.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/kwallet.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/__init__.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/fail.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/OS_X.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/SecretService.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/Windows.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/libsecret.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/backends/chainer.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/backends
copying build/lib/keyring/__init__.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
copying build/lib/keyring/core.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
creating build/bdist.macosx-10.9-universal2/wheel/keyring/testing
copying build/lib/keyring/testing/backend.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/testing
copying build/lib/keyring/testing/util.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/testing
copying build/lib/keyring/testing/__init__.py -> build/bdist.macosx-10.9-universal2/wheel/keyring/testing
copying build/lib/keyring/cli.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
copying build/lib/keyring/http.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
copying build/lib/keyring/py.typed -> build/bdist.macosx-10.9-universal2/wheel/keyring
copying build/lib/keyring/errors.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
copying build/lib/keyring/devpi_client.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
copying build/lib/keyring/__main__.py -> build/bdist.macosx-10.9-universal2/wheel/keyring
running install_egg_info
Copying keyring.egg-info to build/bdist.macosx-10.9-universal2/wheel/keyring-23.2.2.dev7+g0ade53b-py3.10.egg-info
running install_scripts
adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
creating build/bdist.macosx-10.9-universal2/wheel/keyring-23.2.2.dev7+g0ade53b.dist-info/WHEEL
creating '/Users/jaraco/code/main/keyring/dist/tmpyzmeq20t/keyring-23.2.2.dev7+g0ade53b-py3-none-any.whl' and adding 'build/bdist.macosx-10.9-universal2/wheel' to it
adding 'keyring/__init__.py'
adding 'keyring/__main__.py'
adding 'keyring/backend.py'
adding 'keyring/cli.py'
adding 'keyring/core.py'
adding 'keyring/credentials.py'
adding 'keyring/devpi_client.py'
adding 'keyring/errors.py'
adding 'keyring/http.py'
adding 'keyring/py.typed'
adding 'keyring/backends/OS_X.py'
adding 'keyring/backends/SecretService.py'
adding 'keyring/backends/Windows.py'
adding 'keyring/backends/__init__.py'
adding 'keyring/backends/chainer.py'
adding 'keyring/backends/fail.py'
adding 'keyring/backends/kwallet.py'
adding 'keyring/backends/libsecret.py'
adding 'keyring/backends/null.py'
adding 'keyring/backends/macOS/__init__.py'
adding 'keyring/backends/macOS/api.py'
adding 'keyring/testing/__init__.py'
adding 'keyring/testing/backend.py'
adding 'keyring/testing/util.py'
adding 'keyring/util/__init__.py'
adding 'keyring/util/platform_.py'
adding 'keyring/util/properties.py'
adding 'keyring-23.2.2.dev7+g0ade53b.dist-info/LICENSE'
adding 'keyring-23.2.2.dev7+g0ade53b.dist-info/METADATA'
adding 'keyring-23.2.2.dev7+g0ade53b.dist-info/WHEEL'
adding 'keyring-23.2.2.dev7+g0ade53b.dist-info/entry_points.txt'
adding 'keyring-23.2.2.dev7+g0ade53b.dist-info/top_level.txt'
adding 'keyring-23.2.2.dev7+g0ade53b.dist-info/RECORD'
removing build/bdist.macosx-10.9-universal2/wheel

This comment has been minimized.

Sign in to view

Copy link
@webknjaz

webknjaz Oct 27, 2021

Contributor

@jaraco I suppose this needs to be dropped from https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use too?

This comment has been minimized.

Sign in to view

Copy link
@webknjaz

webknjaz Oct 27, 2021

Contributor

And maybe from the PyPUG guides too?

This comment has been minimized.

Sign in to view

Copy link
@jaraco

jaraco Nov 27, 2021

Author Owner

Yes and yes. I welcome issues to track.
requires = ["setuptools>=56", "setuptools_scm[toml]>=3.4.1"]
build-backend = "setuptools.build_meta"

[tool.black]
Expand Down

0 comments on commit aae281a

Please sign in to comment.