Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass mypy and link issues #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Aug 25, 2024

Ref: jaraco/skeleton#143

Upstream issues:

@LecrisUT
Copy link

Just a note, it would be good to include from __future__ import annotations when adding the annotations. With jaraco.test there was an issue with older pytest version not exporting the annotation properly even though internally it works ok.

@Avasam
Copy link
Contributor Author

Avasam commented Sep 18, 2024

@LecrisUT there are no annotations added by this PR

@LecrisUT
Copy link

@LecrisUT there are no annotations added by this PR

I thought that was the main goal of these PRs. Is it only checking mypy annotations of third-party dependencies?

@Avasam
Copy link
Contributor Author

Avasam commented Sep 18, 2024

It's only re-enabling basic mypy type-checking as per jaraco/skeleton#143 . And doing the fixes necessary. Sometimes that includes fixing some annotations or suppression comments, sometimes like this PR, we only need to indicate that we know a dependency is untyped.

Some skeleton-based projects were ready to be strictly checked and/or marked as py.typed, so I marked those as such as I went along (some were only missing a few easy annotations, so I completed those when I felt like it).

Projects that affect setuptools (https://github.com/pypa/setuptools/blob/3106af0512fe67464a8b5e7524c07fddf7717660/mypy.ini#L44-L50) I may put more effort into actually completing annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants