Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor occupancy specialization #31

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Refactor occupancy specialization #31

merged 7 commits into from
Jul 8, 2024

Conversation

jaraco
Copy link
Owner

@jaraco jaraco commented Jul 8, 2024

  • Remove Moisture class, unused.
  • Refactored sensor specialization.
  • Removed Occupancy class.
  • Avoid indirection through 'generic_type' when resolving a Device subclass.
  • Reflect the generic_type from the class instead of manifesting it in the state.
  • Inline the initialization.
  • Add a docstring explaining Device.tags.

@jaraco
Remove Moisture class, unused.
31ecd58
@jaraco
Refactored sensor specialization.
81c8695 
Instead of relying on a confusingly-named 'unknown' sentinel, moved these tags to the `Motion` type and gave that type a `.specialize` method to handle the state-sensitive specialization.

Now a truly "unknown" device will resolve to `Unknown` and will be filtered when loading devices.

Closes #28
@jaraco
Removed Occupancy class.
72126c7 
It seems to provide little value over the Motion class. Ref #28
@jaraco
Avoid indirection through 'generic_type' when resolving a Device subc…
ae89b0a 
…lass.
@jaraco
Reflect the generic_type from the class instead of manifesting it in …
586860f 
…the state.
@jaraco
Inline the initialization.
a87cab4
@jaraco
Add a docstring explaining Device.tags.
8502d8f
@jaraco jaraco merged commit 318f302 into main Jul 8, 2024
26 checks passed
@jaraco jaraco deleted the refactor/occupancy-specialization branch July 8, 2024 11:23
@jaraco jaraco mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaraco