Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

std: Remove rand crate and module #158

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dvc94ch
Copy link

@dvc94ch dvc94ch commented Nov 12, 2017

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
The allocator feature was removed in ralloc commit
cd8d627ecd5eb633833fe9fb8973219c2101ff61.

Closes japaric#153.
@dvc94ch
Copy link
Author

dvc94ch commented Nov 17, 2017

This PR fixes building steed with a recent rust-src version.

Copy link
Owner

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dvc94ch. LGTM. I had a question about the Xargo.toml change though.

Xargo.toml Outdated

[dependencies.compiler_builtins]
features = ["mem"]
git = "https://github.com/rust-lang-nursery/compiler-builtins"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should we switch to the git version? rust-src contains a snapshot of that git repo. Is there some version mismatch problem?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware that compiler-builtins was distributed with rust-src. Should it be removed from the other Xargo.toml files too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid question - I guess it makes sense for the Xargo.test.toml file since it there are a lot of "supported" platforms

collections and rand crates have been removed/replaced.
@japaric
Copy link
Owner

japaric commented Nov 20, 2017

Actually, none of the Xargo.toml should specify compiler-builtins as a git repo.

@japaric
Copy link
Owner

japaric commented Nov 20, 2017

That should work, I think.

@homunkulus r+

@homunkulus
Copy link
Collaborator

📌 Commit e56b319 has been approved by japaric

@homunkulus
Copy link
Collaborator

⌛ Testing commit e56b319 with merge fabd9c0...

japaric pushed a commit that referenced this pull request Nov 20, 2017
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@homunkulus
Copy link
Collaborator

⌛ Testing commit e56b319 with merge 42fde8f...

japaric pushed a commit that referenced this pull request Nov 30, 2017
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@dvc94ch
Copy link
Author

dvc94ch commented Dec 4, 2017

Mmh error[E0463]: can't find crate for std``, I think I had this error too and then it magically disappeared. Any idea why it's trying to find a crate for std?

@japaric
Copy link
Owner

japaric commented Dec 16, 2017

Any idea why it's trying to find a crate for std?

The rand crate from crates.io depends on std. I don't think we need rand to be a dev-dependency though. Removing it should fix the error, I think.

@japaric
Copy link
Owner

japaric commented Dec 16, 2017

@homunkulus r+

@homunkulus
Copy link
Collaborator

📌 Commit 2e9830c has been approved by japaric

@homunkulus
Copy link
Collaborator

⌛ Testing commit 2e9830c with merge a887325...

japaric pushed a commit that referenced this pull request Dec 16, 2017
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@japaric
Copy link
Owner

japaric commented Dec 18, 2017

Problems with the Xargo sysroot. Let's try again.

@homunkulus r+

@homunkulus
Copy link
Collaborator

📌 Commit 5883feb has been approved by japaric

@homunkulus
Copy link
Collaborator

⌛ Testing commit 5883feb with merge bb7c831...

japaric pushed a commit that referenced this pull request Dec 18, 2017
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@homunkulus
Copy link
Collaborator

⌛ Testing commit 5883feb with merge 0c28304...

japaric pushed a commit that referenced this pull request Jan 12, 2018
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@homunkulus
Copy link
Collaborator

⌛ Testing commit 5883feb with merge e5eed94...

japaric pushed a commit that referenced this pull request Jan 13, 2018
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@homunkulus
Copy link
Collaborator

⌛ Testing commit 5883feb with merge 61608e0...

japaric pushed a commit that referenced this pull request Jan 23, 2018
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@homunkulus
Copy link
Collaborator

⌛ Testing commit 5883feb with merge 08639da...

japaric pushed a commit that referenced this pull request Jan 24, 2018
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

@homunkulus
Copy link
Collaborator

⌛ Testing commit 5883feb with merge aec06de...

japaric pushed a commit that referenced this pull request Feb 17, 2018
std: Remove `rand` crate and module

I'm guessing the entire rand folder can be deleted (still contains rand/reader.rs), but I left it for now, since it wasn't removed in rust/src/libstd yet.

Rust lang commit: 6bc8f164b09b9994e6a2d4c4ca60d7d36c09d3fe
@homunkulus
Copy link
Collaborator

💔 Test failed - status-travis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants