Node.js example updated for v0.10 with npm #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes to the Node.js example that make it easier to build and run the example with Node v0.10.26
Previously, there was no package.json file, meaning the user couldn't just run
npm installand get the required modules.Small syntax issues in rpx.js meant that the server could not start with Node v0.10.26. Now fixed.
Possible Issue: regression of earlier Node support
It's likely that this update will cause the code to break with Node 0.8 or earlier. As this release is over a year old, and the examples are expected to be in use for new deploys, this seems like a small concern.