Implemented debase #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(let me know if you would like me to write tests for this, or if you'd like to handle that yourself) |
|
Realized this needs a break in the second loop. Also, I had a simple idea for how to implement tests, so I'll go ahead and do that |
This reverts commit ea34b65.
|
realized this would not work if nested dirs aligned with the same name. Going to check whole path up to that point instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey y'all!
I wanted to use this in my project, however due to the npm issues (fix didn't work for me) I figured as it should only be a dev dependency, it's almost necessary for me to rebuild the imports when deploying. So I made changes to the rebase to achieve this. It works in my project, so hopefully you'll find that it's robust enough in your testing :)