Fix compatibility with Minitest 5.19+ #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MiniTest` was renamed to `Minitest`: minitest/minitest@9a57c52 And the `MiniTest` constant is now loaded just when `MT_COMPAT` environment variable is set: minitest/minitest@a2c6c18 This fixes following issue: ~~~ $ ruby -Ilib:test -e 'Dir.glob "./test/**/*_test.rb", &method(:require)' /builddir/build/BUILD/test/test_helper.rb:17:in `<top (required)>': uninitialized constant MiniTest (NameError) class MiniTest::Test ^^^^^^^^ Did you mean? Minitest from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require' from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require' from /builddir/build/BUILD/image_processing-1.12.2/usr/share/gems/gems/image_processing-1.12.2/test/builder_test.rb:1:in `<top (required)>' from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require' from <internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb>:85:in `require' from <internal:dir>:220:in `glob' from -e:1:in `<main>' ~~~
|
It does not seem the test failure would be related to this PR |
|
Thanks for the patch! Yes, the test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MiniTestwas renamed toMinitest:minitest/minitest@9a57c52
And the
MiniTestconstant is now loaded just whenMT_COMPATenvironment variable is set:minitest/minitest@a2c6c18
This fixes following issue: