Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packaging): Update DevDependencies to the latest #48 #49

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

killerkc12
Copy link
Contributor

Summary

This PR contains changes for DevDependencies which have been updated to the latest.
These steps are used for updating the dev dependencies:

  • npm install -g npm-check-updates
  • ncu -u

Linked issue(s)

#48

@killerkc12 killerkc12 mentioned this pull request Oct 12, 2023
@killerkc12
Copy link
Contributor Author

killerkc12 commented Oct 12, 2023

@jankapunkt Looks like the build failed because package-lock.json was not updated as per your request.
image
Should I update the package-lock.json file as well?

@jankapunkt
Copy link
Owner

No worries that's expected here because I said to not update package lock. Background of this is that reviewing the package lock is really time intensive and error prone. I will rather generate it afterwards. I will review later .

@jankapunkt jankapunkt merged commit 3690ba8 into jankapunkt:master Oct 16, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants