Skip to content

BaseViewModel holds hard reference to Navigators which can lead to le… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

BaseViewModel holds hard reference to Navigators which can lead to le… #23

merged 1 commit into from
May 22, 2018

Conversation

@legalimpurity
Copy link
Contributor

@legalimpurity legalimpurity commented May 19, 2018

BaseViewModel holds hard reference to Navigators which can lead to leaks. Would suggest to wrap them up in weak references.

@amitshekhariitbhu amitshekhariitbhu merged commit 432ffbc into janishar:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amitshekhariitbhu amitshekhariitbhu amitshekhariitbhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legalimpurity @amitshekhariitbhu