Skip to content

Conversation

@louis-jan
Copy link
Contributor

Describe Your Changes

This PR fixes an issue where app uses GGUF base name to set model name, hence models with the same GGUF base name will not be imported. Users often distinguish imported models by the file name instead.

Some of the models use very unclear base name, such as Jan V2 VL has base name "checkpoint".

Screenshot 2025-12-03 at 11 55 45

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue where the app was using GGUF metadata's general.basename field to set model names during import, causing conflicts when multiple models share the same basename. The change switches to using the file's filename instead, which users can better control to distinguish their imported models.

Key Changes

  • Removed logic that extracts and uses general.basename from GGUF metadata
  • Switched to using basename(filePath) from the Node.js path module for model naming
  • Added import for basename from the 'path' module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@louis-jan louis-jan merged commit 8c20ae3 into release/v0.7.4 Dec 3, 2025
24 of 26 checks passed
@louis-jan louis-jan deleted the fix/model-import-name branch December 3, 2025 08:15
@github-actions github-actions bot added this to the v0.7.6 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants