refactor: clean up JoyRide #7073
Open
+67
−517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated JoyRide (react-joyride) library and associated code that was used for providing guided tours to users during the setup process. The cleanup removes the component implementation, dependency, translations across all supported languages, and the main usage in the provider settings page.
Key Changes:
- Removed
react-joyridepackage dependency from package.json - Deleted CustomTooltipJoyRide component that implemented custom tour UI
- Removed JoyRide-related translations from all 13 language locale files (providers.json and hub.json)
- Cleaned up JoyRide component usage and related code from the provider settings page
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web-app/package.json | Removed react-joyride dependency |
| web-app/src/containers/CustomeTooltipJoyRide.tsx | Deleted the custom JoyRide tooltip component |
| web-app/src/routes/settings/providers/$providerName.tsx | Removed JoyRide component usage, imports, steps configuration, and callback handler; improved code formatting/indentation |
| web-app/src/locales/*/providers.json (13 files) | Removed JoyRide translation keys for provider setup tour |
| web-app/src/locales/*/hub.json (13 files) | Removed JoyRide translation keys for model hub tour |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Vanalite
reviewed
Dec 2, 2025
| const { status } = data | ||
|
|
||
| if (status === STATUS.FINISHED) { | ||
| localStorage.setItem(localStorageKey.setupCompleted, 'true') |
Contributor
There was a problem hiding this comment.
This key still remains in localStorage and will never be used again @louis-jan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist