Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default modalities and simple modal modules #97

Open
wants to merge 6 commits into
base: jane
Choose a base branch
from

Conversation

tdelvecchio-jsc
Copy link

Enables adding @@ portable at the top of an mli file (and at the beginning of sig ... end blocks), as well as marking module declarations with modes:

@@ portable

val portable : unit -> unit
val nonportable : unit -> unit @@ nonportable

module (T @ nonportable) : sig @@ portable
  val portable : unit -> unit
  val nonportable : unit -> unit @@ nonportable
end

This is enough to get us started adding portability to our code, though there is more syntax to implement in the future.

Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com>
Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com>
Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com>
Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com>
Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com>
… fix issue with default modalities in empty signatures.

Signed-off-by: Thomas Del Vecchio <tdelvecchio@janestreet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants