Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the nonlocal_ modality #23

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

riaqn
Copy link

@riaqn riaqn commented Jun 13, 2023

Corresponding to ocaml-flambda/flambda-backend#1452 , this PR removes the support for the nonlocal_ modality in ocamlformat.

Kindly request review from @ccasin

@riaqn riaqn force-pushed the ocamlformat-remove-nonlocal branch from 20fc17b to 4005488 Compare June 13, 2023 08:56
Copy link

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Will hold off on merging until the relevant compiler has been released.

Signed-off-by: Zesen Qian <github@riaqn.org>
@riaqn riaqn force-pushed the ocamlformat-remove-nonlocal branch from 4005488 to d5d4f48 Compare June 22, 2023 15:22
riaqn added 2 commits June 22, 2023 16:42
Signed-off-by: Zesen Qian <github@riaqn.org>
Signed-off-by: Zesen Qian <github@riaqn.org>
@tdelvecchio-jsc tdelvecchio-jsc merged commit 2d4e4b2 into janestreet:jane Jun 23, 2023
tdelvecchio-jsc pushed a commit that referenced this pull request Jul 20, 2023
* remove nonlocal_

Signed-off-by: Zesen Qian <github@riaqn.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants