Fix marshalling causing crashes with using the -fork flag. - #27
Open
WINSDK wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nicolas Mazzon <nicolasmazzon549@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing on MacOS I was running my benchmarks with the
-forkflag.This causes every benchmark to throw an exception with:
It appears that when using
-fork, each measurement is marshalled over a pipe.However measurements have samples and their samples include an
extrafield which can't be marshalled.I've changed the samples using a
Mapto just using an association list which fixes the issue.