Add bulk delete, bulk archive/unarchive, and bulk metadata edit buttons in books table page #3113
Conversation
jmarmstrong1207
changed the title
|
I prefer to have the buttons for mass delete/unarchive in the top of the table, similar to the ones in the user edit table (.../admin/usertable): |
|
Looks like this now. It looks off; is this style good? I'm also thinking of adding bulk read status buttons too in this PR |
|
Okay, got it to work. Had to use Also added the bulk read/unread buttons. I have tested it to work, but of course testing yourself would be best |
|
Alright, final feature for this PR. I added bulk metadata editing. No more additional features will be added from now on as I've done what I intended to do! |
jmarmstrong1207
changed the title
jmarmstrong1207
force-pushed
the
bulk-delete
branch
from
f56f044 to
ab3d4e4
Compare
jmarmstrong1207
force-pushed
the
bulk-delete
branch
from
2a3bc12 to
96fb2c1
Compare
jmarmstrong1207
changed the title
|
Let me know if I am missing anything. Fleshed out basically everything I can think of myself |
jmarmstrong1207
force-pushed
the
bulk-delete
branch
from
ebeb87f to
a335dd7
Compare
| @@ -350,6 +350,74 @@ def table_get_custom_enum(c_id): | |||
| @edit_required | |||
| def edit_list_book(param): | |||
There was a problem hiding this comment.
I moved the function to edit_book_param() in order to modularize it. This is so it can be used with the '/editselectedbooks/' calls. This essentially makes the change atomic from the client's perspective. Otherwise when bulk editing metadata, each metadata for each book needs an individual rest API call.
cps/kobo_sync_status.py
Outdated
| @@ -54,10 +54,10 @@ def remove_synced_book(book_id, all=False, session=None): | |||
| def change_archived_books(book_id, state=None, message=None): | |||
| archived_book = ub.session.query(ub.ArchivedBook).filter(and_(ub.ArchivedBook.user_id == int(current_user.id), | |||
| ub.ArchivedBook.book_id == book_id)).first() | |||
| if not archived_book: | |||
| if not archived_book and state == True: | |||
There was a problem hiding this comment.
Makes it so only requests to archive (ie state = true) actually creates an archivedbook listing.
Edit: Made line 57 if not archived_book and (state == True or state == None) so state=None makes the function a toggler. Otherwise, not adding or state == None will make it not create an archivedbook listing when someone tries to use the /togglearchived endpoint on a brand new, never-archived book
| archived_book = ub.ArchivedBook(user_id=current_user.id, book_id=book_id) | ||
|
|
||
| archived_book.is_archived = state if state else not archived_book.is_archived | ||
| archived_book.is_archived = state if state != None else not archived_book.is_archived |
There was a problem hiding this comment.
Without this, bulk unarchiving on already-unarchived books will actually archive them instead. Without this, this function is just a toggler if state is false.
Same exact thing with edit_book_read_status is fixed in the commit below
|
@OzzieIsaacs This PR is ready to review now, whenever you're ready |
|
Do you know if this will be reviewed soon? @OzzieIsaacs |
|
I'll have a look at it. My request regarding buttons was a bit ambigious, the read/unread unarchive/archive ones should be radio buttons as on the user page. I'm feeling guilty for it, so I will change it by myself and I also will add the "select all" button. From the functionality it looks good |
This PR adds the following:
Screenshots below show the workflow for deleting for end-users, but is the same as for archive/unarching in bulk. Read comments below for more screenshots:
Select books
Delete books
Book list after deletion