-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick search improvements #2772
base: Develop
Are you sure you want to change the base?
Conversation
…in the same query. Also word order does not matter anymore. +some more comments
I think this is now ready for review. I added fuzzy matching for all search categories but custom-columns. I was not able to understand what they do, so search behavior for those remains unchanged. Also, this change does not affect the advanced search feature. Please let me know if there's anything to clear up. |
…esulted in many more dependencies than needed. These are the actually relevant requirements for this pr.
I found some issues with longer queries. |
…than 4 letters for searching, introduced max_ratio at new filter function
…pare term to words > 3 letters of book attributes
Books now also get sorted based on how close they are to the search parameters. Words < 3 letters get ignored in both the search query and book attributes when filtering. If the query does not contain words longer than 3 letters, no results are returned. |
@OzzieIsaacs Have you had time to look at this yet? What do you think? |
Would this PR also address issues where Calibre search returns completely different results than Calibre Web? #2805 Seems like calibre web might be filtering out works that doen't have the same columns. |
Given that this search version is a lot more forgiving, I'd say there's a good chance it does at least improve that issue |
@OzzieIsaacs just want to remind you that this PR exists. I think this would be a big improvement to the current search |
removed unwanted refactoring
Currently the quick search bar only allows searching for either title or author, not a combination or different word order.
With this pr, author and title can be searched together and word order does not matter anymore.
Ideally I want to implement a way to ignore typos as well.