Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to view previously added allowed/denied tags after adding a tag that includes a quote mark #2097

Closed
fivestones opened this issue Aug 26, 2021 · 2 comments
Labels

Comments

@fivestones
Copy link

Describe the bug/problem
After adding a tag to the allowed/denied tags for a user, if that tag includes a quote mark ('), the allow/deny buttons don't seem to do anything, and when opening the allowed/denied tag dialog subsequently, no previously added tags are visible. It seems that new tags can still be allowed and denied, but you are unable to delete previously added tags or even see them.

To Reproduce
Steps to reproduce the behavior:
Go to Admin. Click on a user's name. Click on Add allowed/denied tags. Add a tag that includes a quote mark (in my case the tag is "Children's Books". Click on allow or deny. Nothing appears to happen. Close the dialog box. Open it again by clicking on Add allowed/denied tags. Now none of the tags that had previously been added to allow/deny are visible.

Logfile
Add content of calibre-web.log file or the relevant error, try to reproduce your problem with "debug" log-level to get more output.
[2021-08-26 17:34:30,444] INFO {cps.ub:829} Changed allowed tags of user x to ['Fiction']
[2021-08-26 17:34:43,361] INFO {cps.ub:829} Changed denied tags of user x to ['Non-Fiction']
[2021-08-26 17:35:54,434] INFO {cps.ub:829} Changed allowed tags of user x to ['Fiction', 'Ages 5 and up']
[2021-08-26 17:36:34,312] INFO {cps.ub:829} Changed allowed tags of user x to ['Fiction', 'Ages 5 and up', "Children's Books"]
[2021-08-26 17:36:40,294] INFO {cps.ub:829} Changed allowed tags of user x to ['Fiction', 'Ages 5 and up', "Children's Books"]

Expected behavior
A clear and concise description of what you expected to happen.
When adding any tag, including those with quote marks, the given tag should be allowed or denied, and when opening the allowed/denied tags dialog box, all previously added tags should be visible.

Screenshots
If applicable, add screenshots to help explain your problem.
See attachments.

Environment (please complete the following information):

  • OS: Raspberry Pi OS 64 bit Buster
  • Python version: 3.8.10
  • Calibre-Web version: 8/19/21, 12:17 AM
  • Docker container: gsp8181/calibre-web
  • Special Hardware: Rasperry Pi 4b
  • Browser: Firefox 91.0.1, also Safari 14.1.2 (16611.3.10.1.3)

Additional context
Add any other context about the problem here. [e.g. access via reverse proxy, database background sync, special database location]
None

Normal procedure, adding allowed/denied tags:
Screen Shot 2021-08-26 at 5 34 19 PM
Screen Shot 2021-08-26 at 5 34 13 PM
Screen Shot 2021-08-26 at 5 34 36 PM
Screen Shot 2021-08-26 at 5 34 49 PM
Screen Shot 2021-08-26 at 5 36 30 PM

After adding Children's Books tag:
After adding  Children's Books  tag

@OzzieIsaacs
Copy link
Collaborator

After the container is updated, the texts should show up properly. Please leave the issue open as reminder that I have to report this issue in the bootstrap-table repository

@fivestones
Copy link
Author

Thanks a million! It works great now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants