Expand is_async_callable test coverage and clarify naming #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split class method tests; add multi-level partial tests for plain functions; add hybrid sync __call__ returning coroutine test; rename inspect test for consistency.
…ng type annotations
janbjorge
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR expands test coverage for the is_async_callable utility function and improves test naming clarity. The changes focus on ensuring comprehensive testing of various callable patterns including class methods, callable instances, nested partial functions, and decorator wrappers.
- Renamed existing test for better clarity and split it into separate async/sync test cases
- Added comprehensive test coverage for callable instances, multi-level partial functions, and decorator patterns
- Added edge case tests for sync functions that return coroutine objects and hybrid callable patterns
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.