Skip to content

Commit b954ed7

Browse files
committed
Fix ES|QL sample csv tests (elastic#127838)
1 parent d2f0492 commit b954ed7

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/resources/sample.csv-spec

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// range. These stats should be correctly adjusted for the sampling. Furthermore,
55
// they also assert the value of MV_COUNT(VALUES(...)), which is not adjusted for
66
// the sampling and therefore gives the size of the sample.
7-
// All ranges are very loose, so that the tests should fail less than 1 in a billion.
7+
// All ranges are very loose, so that the tests should practically never fail.
88
// The range checks are done in ES|QL, resulting in one boolean value (is_expected),
99
// because the CSV tests don't support such assertions.
1010

@@ -40,10 +40,10 @@ required_capability: sample
4040
FROM employees
4141
| SAMPLE 0.5
4242
| STATS count = COUNT(), values_count = MV_COUNT(VALUES(emp_no)), avg_emp_no = AVG(emp_no), sum_emp_no = SUM(emp_no)
43-
| EVAL is_expected = count >= 40 AND count <= 160 AND
44-
values_count >= 20 AND values_count <= 80 AND
43+
| EVAL is_expected = count >= 20 AND count <= 180 AND
44+
values_count >= 10 AND values_count <= 90 AND
4545
avg_emp_no > 10010 AND avg_emp_no < 10090 AND
46-
sum_emp_no > 40*10010 AND sum_emp_no < 160*10090
46+
sum_emp_no > 20*10010 AND sum_emp_no < 180*10090
4747
| KEEP is_expected
4848
;
4949

@@ -59,8 +59,8 @@ FROM employees
5959
| SAMPLE 0.5
6060
| WHERE emp_no > 10050
6161
| STATS count = COUNT(), values_count = MV_COUNT(VALUES(emp_no)), avg_emp_no = AVG(emp_no)
62-
| EVAL is_expected = count >= 10 AND count <= 90 AND
63-
values_count >= 5 AND values_count <= 45 AND
62+
| EVAL is_expected = count >= 5 AND count <= 95 AND
63+
values_count >= 2 AND values_count <= 48 AND
6464
avg_emp_no > 10055 AND avg_emp_no < 10095
6565
| KEEP is_expected
6666
;
@@ -77,8 +77,8 @@ FROM employees
7777
| WHERE emp_no <= 10050
7878
| SAMPLE 0.5
7979
| STATS count = COUNT(), values_count = MV_COUNT(VALUES(emp_no)), avg_emp_no = AVG(emp_no)
80-
| EVAL is_expected = count >= 10 AND count <= 90 AND
81-
values_count >= 5 AND values_count <= 45 AND
80+
| EVAL is_expected = count >= 5 AND count <= 95 AND
81+
values_count >= 2 AND values_count <= 48 AND
8282
avg_emp_no > 10005 AND avg_emp_no < 10045
8383
| KEEP is_expected
8484
;
@@ -95,8 +95,8 @@ FROM employees
9595
| SAMPLE 0.5
9696
| SORT emp_no
9797
| STATS count = COUNT(), values_count = MV_COUNT(VALUES(emp_no)), avg_emp_no = AVG(emp_no)
98-
| EVAL is_expected = count >= 40 AND count <= 160 AND
99-
values_count >= 20 AND values_count <= 80 AND
98+
| EVAL is_expected = count >= 20 AND count <= 180 AND
99+
values_count >= 10 AND values_count <= 90 AND
100100
avg_emp_no > 10010 AND avg_emp_no < 10090
101101
| KEEP is_expected
102102
;
@@ -113,8 +113,8 @@ FROM employees
113113
| SORT emp_no
114114
| SAMPLE 0.5
115115
| STATS count = COUNT(), values_count = MV_COUNT(VALUES(emp_no)), avg_emp_no = AVG(emp_no)
116-
| EVAL is_expected = count >= 40 AND count <= 160 AND
117-
values_count >= 20 AND values_count <= 80 AND
116+
| EVAL is_expected = count >= 20 AND count <= 180 AND
117+
values_count >= 10 AND values_count <= 90 AND
118118
avg_emp_no > 10010 AND avg_emp_no < 10090
119119
| KEEP is_expected
120120
;
@@ -147,8 +147,8 @@ FROM employees
147147
| LIMIT 50
148148
| SAMPLE 0.5
149149
| STATS count = COUNT(), values_count = MV_COUNT(VALUES(emp_no))
150-
| EVAL is_expected = count >= 10 AND count <= 90 AND
151-
values_count >= 5 AND values_count <= 45
150+
| EVAL is_expected = count >= 5 AND count <= 95 AND
151+
values_count >= 2 AND values_count <= 48
152152
| KEEP is_expected
153153
;
154154

@@ -201,8 +201,8 @@ FROM employees
201201
| SAMPLE 0.8
202202
| SAMPLE 0.9
203203
| STATS count = COUNT(), values_count = MV_COUNT(VALUES(emp_no)), avg_emp_no = AVG(emp_no)
204-
| EVAL is_expected = count >= 40 AND count <= 160 AND
205-
values_count >= 20 AND values_count <= 80 AND
204+
| EVAL is_expected = count >= 20 AND count <= 180 AND
205+
values_count >= 10 AND values_count <= 90 AND
206206
avg_emp_no > 10010 AND avg_emp_no < 10090
207207
| KEEP is_expected
208208
;

0 commit comments

Comments
 (0)