-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Fix ES|QL sample csv tests #127838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix ES|QL sample csv tests #127838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (Team:ML) |
alex-spies
approved these changes
May 7, 2025
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jun 18, 2025
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jun 18, 2025
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jun 18, 2025
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jun 19, 2025
jan-elastic
added a commit
that referenced
this pull request
Jun 19, 2025
* ES|QL random sampling (#125570) * test: check ES|QL SAMPLE capability before running analyzer/parser tests (#127382) This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests. * Fix ES|QL sample csv tests (#127838) * Remove optional seed from ES|QL SAMPLE (#128887) * Remove optional seed from ES|QL SAMPLE * make it clear that seed is for testing * rename ES|QL sample capability (#129193) * remove stats correction from ES|QL sample (#129319) * remove stats correction from ES|QL sample * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> * Allow parameter for ES|QL SAMPLE (#129392) * Allow parameter for ES|QL SAMPLE * fix test to work around issue #120272 * remove unused postAnalysisVerification * docs * [CI] Auto commit changes from spotless * fix usage * Move ES|QL sample command from snapshot to tech preview (#129540) * Move ES|QL sample command from snapshot to tech preview * dev_sample -> sample * fix test * fix grammar --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:ml
Machine learning
needs:risk
Requires assignment of a risk label (low, medium, blocker)
Team:ML
Meta label for the ML team
>test-failure
Triaged test failures from CI
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/elastic/elasticsearch-serverless/issues/3864
After some more experimentation, the loose bounds were still too tight