-
Notifications
You must be signed in to change notification settings - Fork 123
Version 0.5.0 Levenstein updates and fuzzy matching #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fbennett
commented
Jan 23, 2018
- Graceful Levenshtein updating of search list
- Search queries as fuzzy match to each term, joined by AND
- Force query words to lowercase
- Fix an issue with failure of DOM updates on first search
- Update README
- Update changelog.txt
Hope this checks out okay in trials! |
I'll look at it this weekend, kinda swamped ATM. Quick question: you changed from .4 to .5 - does that mean you're expecting breaking changes ? Cheers |
No rush at all. The changes require an |
fb3df60
to
58126fd
Compare
I just force-pushed a further small change. Testing locally, we found that search could be broken if user made a search attempt immediately on first access to the site. Running |
0568be9
to
a7bcd81
Compare
Fixed a couple of other bugs, including what looks like a change in the way dates are handled in some contexts---the tool worked on our production server with MySQL and Ghost v1.20.0, and failed locally on a v1.20.3 sqlite3 installation. A tweak to normalize the date form for an API call fixed it. Should be pretty solid at this point. |
You're fixing stuff too fast xD I'll look at it this weekend, thanks
Sent from BlueMail<http://www.bluemail.me/r?b=11745>
On Jan 25, 2018, at 16:09, Frank Bennett <notifications@github.com<mailto:notifications@github.com>> wrote:
Fixed a couple of other bugs, including what looks like a change in the way dates are handled in some contexts---the tool worked on our production server with MySQL and Ghost v1.20.0, and failed locally on a v1.20.3 sqlite3 installation. A tweak to normalize the date form for an API call fixed it. Should be pretty solid at this point.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#45 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARG2-65ZVoESjd2UgxPLgwAExYHRPeANks5tOJkMgaJpZM4Rpfb1>.
|
Yeah, it got to be a little obsessive there for a bit. Should be settled now, though. Have a good weekend! |
a7bcd81
to
f158a5b
Compare
Rats. Searches are behaving weirdly on first-access with iOS devices. Erratically. Working on it, but not ready for merge yet. More soon ... |
Pretty sure I found the problem. It looks to be a bug in |
f158a5b
to
afae968
Compare
There we go, the deed is done. We're now getting identical results without crashes on Linux and iOS devices. I've squashed everything into a single commit. I think this does it. 🤞 |
afae968
to
d2f6367
Compare
* Graceful Levenshtein updating of search list * Search queries as fuzzy match to each term, joined by AND * Force query words to lowercase * Run index_start immediately if index requires updating. (the better to block search attempts until an index is available) * Fix lunr.js bug affecting iOS systems, use static copy of module * Use custom_excerpt for indexed description * Update README * Update changelog.txt
d2f6367
to
17a4db5
Compare
Added one more small tweak. The |
@fbennett I ahven't forgotten you, I got a bit swamped, sorry. I'll finish testing and put it live by Sunday barring any issues. |
No worries at all. I know swamped. |
thanks :) |