The deck analysis should recognize Phyrexian mana

[Dabil]

I added a field isp to the card structure that will be used to recognize Phyrexian mana. That way it can be displayed in the deck analysis with the correct amount of cards.

[jamuraa]

Realistically, we shouldn't use these fields anyway, and just calculate the colors of the cards from their mana cost.

[Dabil]

I was wondering why you didn't already do that. I thought it might be a speed thing, or a code readibility thing, or maybe it just simplified the algorythm. So I thought I would just follow the convention.

[jamuraa]

It is legacy from the older code. I don't know why it was included in
the code which I inherited.

Michael Janssen --- Jamuraa --- jamuraa@base0.net

On Fri, Feb 17, 2012 at 11:54 AM, Dabil
reply@reply.github.com
wrote:

I was wondering why you didn't already do that. I thought it might be a speed thing, or a code readibility thing. So I thought I would just follow the convention.

---

Reply to this email directly or view it on GitHub:
#40 (comment)