Correct vim modeline in ChangeLog#3450
Merged
ann0see merged 2 commits intojamulussoftware:mainfrom Dec 29, 2024
Merged
Conversation
ann0see
approved these changes
Dec 28, 2024
pljones
reviewed
Dec 29, 2024
ChangeLog
Outdated
| - initial version | ||
|
|
||
| <!-- vim: syntax=Markdown --> | ||
| <!-- vim: syntax=Markdown: set ft=markdown: --> |
Collaborator
There was a problem hiding this comment.
Maybe use the full form of the setting - filetype - rather than an abbreviation?
Collaborator
There was a problem hiding this comment.
(Could do with filetype=cfg in Jamulus.pro, too.)
Member
Author
There was a problem hiding this comment.
(Could do with
filetype=cfginJamulus.pro, too.)
Good idea. Though I'll do that separately from this bug fix.
Member
Author
There was a problem hiding this comment.
(Could do with
filetype=cfginJamulus.pro, too.)
cfg is an ok generic filetype for Jamulus.pro, but better is to install the syntax and filetype detect files from https://github.com/artoj/qmake-syntax-vim
pljones
approved these changes
Dec 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Update the vim modeline in
ChangeLogto fix vim error and enable syntax highlightingCHANGELOG: SKIP
Context: Fixes an issue?
The vim modeline that was added to
ChangeLogin #2899 is enough to make Github render the file as Markdown, but it results in vim errors when editing the file:It is because the closing comment tag
-->is interpreted by vim as a command. In addition, thesyntax=Markdowndoes not turn on syntax highlighting within vim. For that,set ft=markdown:is needed, and the trailing:prevents the-->from being interpreted by vim.Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Ready to merge
What is missing until this pull request can be merged?
Nothing
Checklist