Skip to content

test: stub connection in unit test to emulate multi adapter support within the same suite #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2021

Conversation

mberlanda
Copy link
Collaborator

@mberlanda mberlanda commented Feb 7, 2021

Tests are currently running assuming the adapter is always sqlite.
This PR introduce:

  • a check to use the stub a connection based on the adapter in use
  • added tests for statement adapter
  • stub correctly the connection to avoid to apply always sqlite quoting
  • add missing test cases to ci

@mberlanda mberlanda changed the title test: stub_connection_if_needed test: stub connection in unit test to emulate multi adapter support within the same suite Feb 8, 2021
@mberlanda
Copy link
Collaborator Author

mysql suite is still not passing due to:

  • boolean represented sa tinyint
  • some tests assuming sqlite as default adapter
  • trying to perform real inserts with pg adapters

Count of failing tests: 6

They are going to be addressed in a separated PR

@mberlanda mberlanda merged commit fc4478f into master Feb 8, 2021
@mberlanda mberlanda deleted the mberlanda/fix-ci-mysql-tests branch February 11, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant