fix(backend): guard avatar upload against a missing filename#954
Open
joj0hq wants to merge 1 commit into
Open
Conversation
`UploadFile.filename` can be None, and `Path(None)` raises TypeError. On the avatar endpoint this happens before the try/except, so a filename-less upload surfaces as an unhandled 500 instead of a clean response. Every other upload handler already guards this with `file.filename or ""` (add_profile_sample, transcription, generations); apply the same guard here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe avatar upload handler now safely derives the temporary file suffix when ChangesAvatar upload
Estimated code review effort: 2 (Simple) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
POST /profiles/{profile_id}/avatarbuilds the temp-file suffix fromPath(file.filename).suffix:UploadFile.filenamecan beNone(a multipart part without afilename), andPath(None)raisesTypeError. This line runs before thetry/except, so the error isn't converted to a clean 4xx — the request fails with an unhandled 500.Every other upload handler in the codebase already guards this exact case with
file.filename or "":add_profile_sample—routes/profiles.py:162transcribe—routes/transcription.py:30routes/generations.py:415The avatar endpoint is the lone inconsistency.
Fix
One line — apply the same guard:
A filename-less upload now yields an empty suffix (handled downstream by
upload_avatar, which validates the image) instead of crashing with a 500.🤖 Generated with Claude Code
Summary by CodeRabbit