Merge pull request #51 from cultureamp/translation-fix

fix: incorrect ssh-https URL translation
jamestelfer · Jun 1, 2024 · 0ab4679 · 0ab4679
2 parents 60c6a85 + a232a97
commit 0ab4679
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/internal/vendor/vendor.go b/internal/vendor/vendor.go
@@ -94,7 +94,7 @@ func New(
 	}
 }
 
-var sshUrl = regexp.MustCompile(`^git@github.com:([^/].+)$`)
+var sshUrl = regexp.MustCompile(`^git@github\.com:([^/].+)$`)
 
 func TranslateSSHToHTTPS(url string) string {
 	groups := sshUrl.FindStringSubmatch(url)

diff --git a/internal/vendor/vendor_test.go b/internal/vendor/vendor_test.go
@@ -173,6 +173,11 @@ func TestTransformSSHToHTTPS(t *testing.T) {
 			url:      "git@githab.com:organization/chinmina.git",
 			expected: "git@githab.com:organization/chinmina.git",
 		},
+		{
+			name:     "ssh, another different host",
+			url:      "git@githubxcom:organization/chinmina.git",
+			expected: "git@githubxcom:organization/chinmina.git",
+		},
 		{
 			name:     "ssh, invalid path specifier",
 			url:      "git@github.com/organization/chinmina.git",
@@ -195,8 +200,8 @@ func TestTransformSSHToHTTPS(t *testing.T) {
 		},
 		{
 			name:     "https, nonsense",
-			url:      "https://github.com/organization/chinmina.git",
-			expected: "https://github.com/organization/chinmina.git",
+			url:      "https://githubxcom/passthrough.git",
+			expected: "https://githubxcom/passthrough.git",
 		},
 		{
 			name:     "http, valid",