source-map-cache improvements#1
Merged
jamestalmage merged 4 commits intojamestalmage:cachingfrom Dec 18, 2015
Merged
Conversation
Source maps are applied to a report that was just read from disk. Cloning is needed for the tests but otherwise unnecessary. Change path-related tests to look for the path property on the report, without comparing the report contents. That's silly now that applySourceMaps() doesn't do the cloning. No need to copy coverage.b values when mapping branches.
Use 'report' and fileReport' to be more consistent with index.js.
It was only used by the tests, which can use addMap.
This is no longer used. This was also the last runtime dependency on lodash, which has now been moved to the dev dependencies.
Closed
jamestalmage
added a commit
that referenced
this pull request
Dec 18, 2015
source-map-cache improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
lodasha dev dependency, so maybesource-map-cacheis OK to just require now. Removed theadd()method. Did some bikeshedding so the file is more in line with the rest of nyc.