Remove 'some' from factory return type #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to set the service as a member on a type, you can hit the compilation error:
To work around the compilation error, I could specify
let service: some OpenAIService = .... A better fix, though, is to remove thesomekeyword on the factory methods. We don't needsomehere, because the protocol that our concrete types are conforming to is not a PAT. We don't need to use 'reverse generics' and can instead just rely on vanilla polymorphism through protocols.