Skip to content

Do not throw error for unknown event types #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Do not throw error for unknown event types #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8996c87
refactor: do not throw error for unknown event types. OpenAI might ad…
longseespace Aug 8, 2025
ded3899
fix linting issue
longseespace Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Sources/OpenAI/Public/ResponseModels/Response/ResponseStreamEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ public enum ResponseStreamEvent: Decodable {
/// Emitted when an error occurs
case error(ErrorEvent)

/// For unknown event type
case unknownEventType(String)

public init(from decoder: Decoder) throws {
let container = try decoder.container(keyedBy: CodingKeys.self)
let type = try container.decode(String.self, forKey: .type)
Expand Down Expand Up @@ -237,10 +240,7 @@ public enum ResponseStreamEvent: Decodable {
case "error":
self = try .error(ErrorEvent(from: decoder))
default:
throw DecodingError.dataCorruptedError(
forKey: .type,
in: container,
debugDescription: "Unknown event type: \(type)")
self = .unknownEventType(type)
}
}

Expand Down
4 changes: 1 addition & 3 deletions Tests/OpenAITests/ResponseStreamEventTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,10 +720,8 @@ final class ResponseStreamEventTests: XCTestCase {

do {
_ = try decoder.decode(ResponseStreamEvent.self, from: json.data(using: .utf8)!)
XCTFail("Should have thrown an error for unknown event type")
} catch {
// Expected error
XCTAssertTrue(error is DecodingError)
XCTFail("Should have thrown an error for unknown event type")
}
}
}
Loading