This repository was archived by the owner on Nov 15, 2023. It is now read-only.
java.util.Date support using Spring's CustomDateEditor #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 5, 2017 20:13
Description: 1) add java.util.Date support.
jamesmorgan
suggested changes
Apr 13, 2017
| * Replace callback Properties EventHandler with Guava EventBus | ||
| * Ability to configure usage via spring's @Configuration | ||
|
|
||
| ### Contributions ### | ||
| * Thankyou [normanatashbar](https://github.com/normanatashbar) for adding composite string replacement | ||
| * Thank you [normanatashbar](https://github.com/normanatashbar) for adding composite string replacement |
There was a problem hiding this comment.
Fee free to add you name as a contributor
| static class TestObject { | ||
| Period period = new Period(); | ||
| LocalTime localTime = new LocalTime(); | ||
| LocalDate localDate = new LocalDate(); | ||
| LocalDateTime localDateTime = new LocalDateTime(); | ||
| Date dateValue = new Date(); | ||
| boolean booleanValue; | ||
| } |
There was a problem hiding this comment.
Looks good - can you enhance the integration test ReloadablePropertyPostProcessorIntTest just to prove it all wires together correct and properties can be injected. Thanks for the contribution.
|
Hi James, committed changes you mentioned please review. I am very happy if you merge these changes. |
jamesmorgan
approved these changes
Apr 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi James, this change provide support for converting pre-defined date patterns to java.util.Date.
Changes included.
ConfigurableBeanFactory.getTypeConverter()to get default converter.spring-defaultConfiguration.xml.Please notify me if more changes has to do.