Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the need to re-compile when testing Python code changes #32

Merged
merged 4 commits into from
Dec 29, 2021

Conversation

jameslamb
Copy link
Owner

@jameslamb jameslamb commented Dec 18, 2021

Right now, every run of make cluster-image and make notebook-image needs to re-compile lib_lightgbm. This adds a few minutes to image building.

When testing changes to lightgbm.dask, it's common to only need to change things on the Python side (which shouldn't require recompilation).

This PR proposes compiling lib_lightgbm one time and then re-using that when re-installing the Python package.

Other changes:

  • use Dask version for tags, and allow use of -e DASK_VERSION to test against different versions
  • remove pins on pandas and numpy

@jameslamb jameslamb merged commit 05de439 into main Dec 29, 2021
@jameslamb jameslamb deleted the faster-notebook-install branch December 29, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant