Skip to content

Commit

Permalink
Fix incorrect image reference for DeployImage plugin in test data
Browse files Browse the repository at this point in the history
We generate a sample API in the testdata directory using the DeployImage plugin. However, the flag previously contained incorrect information regarding the image that should be used. This fix ensures the correct image is referenced.
  • Loading branch information
camilamacedo86 committed Oct 25, 2024
1 parent eae8b21 commit 9b6a837
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion test/testdata/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function scaffold_test_project {
if [[ $project =~ multigroup ]] || [[ $project =~ with-plugins ]] ; then
header_text 'With Optional Plugins ...'
header_text 'Creating APIs with deploy-image plugin ...'
$kb create api --group example.com --version v1alpha1 --kind Memcached --image=memcached:memcached:1.6.26-alpine3.19 --image-container-command="memcached,--memory-limit=64,-o,modern,-v" --image-container-port="11211" --run-as-user="1001" --plugins="deploy-image/v1-alpha" --make=false
$kb create api --group example.com --version v1alpha1 --kind Memcached --image=memcached:1.6.26-alpine3.19 --image-container-command="memcached,--memory-limit=64,-o,modern,-v" --image-container-port="11211" --run-as-user="1001" --plugins="deploy-image/v1-alpha" --make=false
$kb create api --group example.com --version v1alpha1 --kind Busybox --image=busybox:1.36.1 --plugins="deploy-image/v1-alpha" --make=false
$kb create webhook --group example.com --version v1alpha1 --kind Memcached --programmatic-validation
header_text 'Editing project with Grafana plugin ...'
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-multigroup/PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ plugins:
options:
containerCommand: memcached,--memory-limit=64,-o,modern,-v
containerPort: "11211"
image: memcached:memcached:1.6.26-alpine3.19
image: memcached:1.6.26-alpine3.19
runAsUser: "1001"
version: v1alpha1
- domain: testproject.org
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-multigroup/config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
- name: BUSYBOX_IMAGE
value: busybox:1.36.1
- name: MEMCACHED_IMAGE
value: memcached:memcached:1.6.26-alpine3.19
value: memcached:1.6.26-alpine3.19
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-multigroup/dist/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1764,7 +1764,7 @@ spec:
- name: BUSYBOX_IMAGE
value: busybox:1.36.1
- name: MEMCACHED_IMAGE
value: memcached:memcached:1.6.26-alpine3.19
value: memcached:1.6.26-alpine3.19
image: controller:latest
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-with-plugins/PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ plugins:
options:
containerCommand: memcached,--memory-limit=64,-o,modern,-v
containerPort: "11211"
image: memcached:memcached:1.6.26-alpine3.19
image: memcached:1.6.26-alpine3.19
runAsUser: "1001"
version: v1alpha1
- domain: testproject.org
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
- name: BUSYBOX_IMAGE
value: busybox:1.36.1
- name: MEMCACHED_IMAGE
value: memcached:memcached:1.6.26-alpine3.19
value: memcached:1.6.26-alpine3.19
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
2 changes: 1 addition & 1 deletion testdata/project-v4-with-plugins/dist/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ spec:
- name: BUSYBOX_IMAGE
value: busybox:1.36.1
- name: MEMCACHED_IMAGE
value: memcached:memcached:1.6.26-alpine3.19
value: memcached:1.6.26-alpine3.19
image: controller:latest
livenessProbe:
httpGet:
Expand Down

0 comments on commit 9b6a837

Please sign in to comment.