-
Notifications
You must be signed in to change notification settings - Fork 121
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
start bringing things inline with rails 2.3
- Loading branch information
1 parent
68a9a5f
commit 02f2fa2
Showing
7 changed files
with
11 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
resource_controller.gemspec |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../../../ |
02f2fa2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this test supposed to work, since only 0.6.6 has been released?
02f2fa2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works because of the symlink in test/vendor/gems. The reason for the ultra high version number is to force it to use the symlink, avoiding collisions with any local gems.
02f2fa2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, if I plugin to a rails app, how to I prepare to run the test suite?
This is how far I got ...
rm -fr q ; time rails q -q
cd q
plugin install git://github.com/jamesgolick/resource_controller.git
cd vendor/plugins/resource_controller/test/
gem install -v=2.3.2 rails
-- next, rake suggested the following was needed.
rake gems:refresh_specs
rake gems
-- resource_controller shows up! as [F] frozen at 10.0.0
-- I don't have a source for thoughtbot-shoulda, so I patched the config.gem directive
vim ./config/environment.rb -- change 'thoughtbot-shoulda' to 'shoulda'
rake db:migrate test
112 tests, 151 assertions, 0 failures, 0 errors
/test/functional/photos_controller_test.rb:14: undefined method `should_be_restful' for PhotosControllerTest:Class (NoMethodError)
Errors running test:functionals!
surely, you have a better way ...
02f2fa2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you're trying to run the tests under a rails app. If you're wanting to hack on r_c, I'd recommend doing that in a separate repository.
As for missing should_be_restful, you'll have to grab shoulda and build a gem from an older revision. They removed it from the framework, and I just don't think it's worth rewriting all the tests.
02f2fa2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've inherited a project that was using r_c.
I am now using
gem 'thoughtbot-shoulda', { :version => '= 2.9.0', :env=> :test, :lib => 'shoulda/rails', :source => "http://gems.github.com" }
Why?
When installed, it breaks rake test:plugins
I'm now showing
475 tests, 786 assertions, 0 failures, 32 errors