Merge pull request meteor#9039 from hwillson/issue-6286

Deprecate fastclick
jamesgibson14 · Sep 4, 2017 · b97f2f9 · b97f2f9
2 parents 99167d4 + 3067c63
commit b97f2f9
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 10 deletions.
diff --git a/History.md b/History.md
@@ -1,5 +1,21 @@
 ## v.NEXT
 
+* The `fastclick` package (previously included by default in Cordova
+  applications through the `mobile-experience` package) has been deprecated.
+  This package is no longer maintained and has years of outstanding
+  unresolved issues, some of which are impacting Meteor users. Most modern
+  mobile web browsers have removed the 300ms tap delay that `fastclick` worked
+  around, as long as the following `<head />` `meta` element is set (which
+  is generally considered a mobile best practice regardless, and which the
+  Meteor boilerplate generator already sets by default for Cordova apps):
+  `<meta name="viewport" content="width=device-width">`
+  If anyone is still interested in using `fastclick` with their application,
+  it can be installed from npm directly (`meteor npm install --save fastclick`).
+  Reference:
+  [Mobile Chrome](https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away)
+  [Mobile Safari](https://bugs.webkit.org/show_bug.cgi?id=150604)
+  [PR #9039](https://github.com/meteor/meteor/pull/9039)
+
 * Minimongo cursors are now JavaScript iterable objects and can now be iterated over
   using `for...of` loops, spread operator, `yield*`, and destructuring assignments.
   [PR #8888](https://github.com/meteor/meteor/pull/8888)

diff --git a/packages/fastclick/.gitignore → packages/deprecated/fastclick/.gitignore b/packages/fastclick/.gitignore → packages/deprecated/fastclick/.gitignore
diff --git a/packages/fastclick/README.md → packages/deprecated/fastclick/README.md b/packages/fastclick/README.md → packages/deprecated/fastclick/README.md
diff --git a/packages/fastclick/fastclick.js → packages/deprecated/fastclick/fastclick.js b/packages/fastclick/fastclick.js → packages/deprecated/fastclick/fastclick.js
diff --git a/packages/fastclick/package.js → packages/deprecated/fastclick/package.js b/packages/fastclick/package.js → packages/deprecated/fastclick/package.js
diff --git a/packages/fastclick/post.js → packages/deprecated/fastclick/post.js b/packages/fastclick/post.js → packages/deprecated/fastclick/post.js
diff --git a/packages/fastclick/pre.js → packages/deprecated/fastclick/pre.js b/packages/fastclick/pre.js → packages/deprecated/fastclick/pre.js
diff --git a/packages/mobile-experience/README.md b/packages/mobile-experience/README.md
@@ -4,6 +4,5 @@
 
 A set of Cordova/PhoneGap-specific packages that set some good defaults when building for mobile. These packages only activate when you are building a native Android or iOS app.
 
-1. [fastclick](https://atmospherejs.com/meteor/fastclick) - avoid the 300ms touch delay
-2. [mobile-status-bar](https://atmospherejs.com/meteor/mobile-status-bar) - avoid the status bar information covering up your app content
-3. [launch-screen](https://atmospherejs.com/meteor/launch-screen) - cover the app with a launch image so that people don’t have to see things loading
+1. [mobile-status-bar](https://atmospherejs.com/meteor/mobile-status-bar) - avoid the status bar information covering up your app content
+2. [launch-screen](https://atmospherejs.com/meteor/launch-screen) - cover the app with a launch image so that people don’t have to see things loading
diff --git a/packages/mobile-experience/package.js b/packages/mobile-experience/package.js
@@ -1,18 +1,12 @@
 Package.describe({
   name: 'mobile-experience',
-  version: '1.0.4',
-  // Brief, one-line summary of the package.
+  version: '1.0.5',
   summary: 'Packages for a great mobile user experience',
-  // By default, Meteor will default to using README.md for documentation.
-  // To avoid submitting documentation, set this field to null.
   documentation: 'README.md'
 });
 
 Package.onUse(function(api) {
   api.imply([
-    // Fastclick: remove the 300 ms click event lag in mobile browsers
-    "fastclick",
-
     // A nicer appearance for the status bar in PhoneGap/Cordova apps
     "mobile-status-bar"
   ], "web.cordova");