-
Notifications
You must be signed in to change notification settings - Fork 241
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Currently, the URL generated for releaseEvent
results in https://github.com/{release.name || release.tag_name}
. Ref.
It should be handled explicitly as with the case of other events in the toUrlFormat
method.
github-activity-readme/index.js
Lines 33 to 40 in 21d9a86
const toUrlFormat = (item) => { | |
if (typeof item === "object") { | |
return Object.hasOwnProperty.call(item.payload, "issue") | |
? `[#${item.payload.issue.number}](${urlPrefix}/${item.repo.name}/issues/${item.payload.issue.number})` | |
: `[#${item.payload.pull_request.number}](${urlPrefix}/${item.repo.name}/pull/${item.payload.pull_request.number})`; | |
} | |
return `[${item}](${urlPrefix}/${item})`; | |
}; |
if (Object.hasOwnProperty.call(item.payload, "release")) {
return `[#${item.payload.release.tag_name || item.payload.release.tag_name}](${item.payload.release.html_url})`;
}
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working