Produce quorum hash directly from scraper stats for superblock validation #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids allocation of a superblock object from scraper stats objects when validating another superblock.
cyrossignol
force-pushed
the
integrated_scraper_2
branch
from
d07fd0c to
6e1f297
Compare
jamescowens
reviewed
Oct 13, 2019
|
Yeah, not a fan of the duplication either... I figured this would be worth it with the potential size of superblocks. I tried to limit duplication as much as possible to a well-defined interface and the unit test should catch cases where we forget to update one side. Worst case we can just remove the custom hashing of |
|
I think it is worth it. I am approving and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids allocation of a superblock object from scraper stats objects when validating another superblock.