Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with latest version of Flutter. #105

Merged
merged 3 commits into from
Nov 11, 2020

Conversation

noordawod
Copy link
Contributor

Latest Flutter version generate a compile error with this module:

/path/to/Flutter/.pub-cache/hosted/pub.dartlang.org/modal_bottom_sheet-1.0.1-dev/lib/src/bottom_sheets/cupertino_bottom_sheet.dart:344:46: Error: No named parameter with the name 'shadowThemeOnly'.
    final isCupertinoApp = Theme.of(context, shadowThemeOnly: true) == null;
                                             ^^^^^^^^^^^^^^^
/path/to/Flutter/packages/flutter/lib/src/material/theme.dart:119:20: Context: Found this candidate, but the arguments don't match.
  static ThemeData of(BuildContext context) {
                   ^^
/path/to/Flutter/.pub-cache/hosted/pub.dartlang.org/modal_bottom_sheet-1.0.1-dev/lib/src/bottom_sheets/material_bottom_sheet.dart:42:32: Error: No named parameter with the name 'shadowThemeOnly'.
      theme: Theme.of(context, shadowThemeOnly: true),
                               ^^^^^^^^^^^^^^^
/path/to/Flutter/packages/flutter/lib/src/material/theme.dart:119:20: Context: Found this candidate, but the arguments don't match.
  static ThemeData of(BuildContext context) {
                   ^^

FAILURE: Build failed with an exception.

@ltdangkhoa
Copy link

LGTM
@jamesblasco can you approve this PR for quick fix on the bugs

@jamesblasco jamesblasco merged commit c0a3b4c into jamesblasco:master Nov 11, 2020
@noordawod noordawod deleted the bugfix/theme-of branch November 11, 2020 10:22
@noordawod
Copy link
Contributor Author

You're welcome ;)

@jamesblasco
Copy link
Owner

Thank you :)

@noordawod
Copy link
Contributor Author

Was this released?

@jamesblasco
Copy link
Owner

Yes in version 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants