Refactor transport layer abstraction #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses concerns regarding the utility of `AbstractTransport` and `TransportInterface`.
Key changes:
- I removed unused utility methods (`encodeMessage`, `decodeMessage`) and constant (`MAX_MESSAGE_SIZE`) from `AbstractTransport`.
- I removed the default `log()` implementation from `AbstractTransport`.
- Based on your feedback and the minimal remaining functionality in `AbstractTransport` (only a default `preferSseStream` method), `AbstractTransport.php` has been removed entirely.
- `StdioTransport` and `HttpTransport` now directly implement `TransportInterface`.
- `StdioTransport` implements `preferSseStream` as a no-op. Its specific `log()` method for STDERR output is now a direct public method, not part of the interface.
- `HttpTransport` implements `preferSseStream`.
- The `log()` method declaration was removed from `TransportInterface` as it was not called polymorphically by the `Server` and `HttpTransport` did not require it. This simplifies the interface for `HttpTransport`.
These changes streamline the transport hierarchy, remove dead code, and clarify the roles of the transport components, while ensuring all existing tests and linting checks pass.
🧪 Test Results SummaryPHPUnit Tests✅ All tests passed! Details: OK (232 tests, 939 assertions)
Code Quality
📁 Detailed Reports
This comment will update automatically when you push new commits. Code Coverage
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses concerns regarding the utility of
AbstractTransportandTransportInterface.Key changes:
encodeMessage,decodeMessage) and constant (MAX_MESSAGE_SIZE) fromAbstractTransport.log()implementation fromAbstractTransport.AbstractTransport(only a defaultpreferSseStreammethod),AbstractTransport.phphas been removed entirely.StdioTransportandHttpTransportnow directly implementTransportInterface.StdioTransportimplementspreferSseStreamas a no-op. Its specificlog()method for STDERR output is now a direct public method, not part of the interface.HttpTransportimplementspreferSseStream.log()method declaration was removed fromTransportInterfaceas it was not called polymorphically by theServerandHttpTransportdid not require it. This simplifies the interface forHttpTransport.These changes streamline the transport hierarchy, remove dead code, and clarify the roles of the transport components, while ensuring all existing tests and linting checks pass.