Skip to content

Use latest version (1.3.0) of james-browser-launcher #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

nerdbeere
Copy link
Member

Hey guys,

I saw some fixes being implemented on james-browser-launcher.
Here's a small PR to set the correct version number.

One other thing:
What do you think about fixating all the dependencies?

@nerdbeere nerdbeere requested a review from mitchhentges June 4, 2017 07:54
@mitchhentges
Copy link
Member

I'd like to refrain from bumping james-browser-launcher here until we're able to test all browsers on all platforms. I released jbl#58 and jbl#62 under a new "major" release so that, if there's any regressions (beyond what already existed in 1.2.6, oops), projects won't run into them until they go up a major version.

So, TL;DR: james-browser-launcher has gone up a major release because the change is potentially not stable ('cause we're not able to test on all platforms yet). Yet, 1.3.0 was released anyway so that we aren't blocking Marcelo (the cool guy providing PRs).

Once I'm in Sweden, I'll have access to a Mac, and can double-check all platforms, ensure 1.3.0 is fully stable, and bump james.
Of course, if you're able to test on all platforms and it works without any issues, then 👍 let's do it. Otherwise, I'm a little nervous

@nerdbeere
Copy link
Member Author

nerdbeere commented Jun 5, 2017

Here's some browser testing on windows, macos and ubuntu 17.04. I will keep updating this comment.

Windows 10

james

General unexpected behavior:

  • Internet Explorer 11 gets detected twice
  • Edge does not show up

Edge 40 (40.15063.0.0)

  • detection
  • browser startup via james
  • proxy setup via james

Internet Explorer 11 (11.0.15063.0)

  • detection
  • browser startup via james
  • proxy setup via james

Chrome 58 (58.0.3029.110)

  • detection
  • browser startup via james
  • proxy setup via james

Firefox 53 (53.0.3.6347)

  • detection
  • browser startup via james
  • proxy setup via james

Opera 45 (45.0.2552.888)

  • detection
  • browser startup via james
  • proxy setup via james

MacOS Sierra (10.12.4)

screen shot 2017-06-05 at 11 32 01

General unexpected behavior:

  • Safari startup takes a very long time This behavior is gone after a reboot
  • Opera doesn't get detected for some reason (weird thing is, I can't even start it using Alfred. It doesn't show up)

Safari

  • detection
  • browser startup via james
  • proxy setup via james

Chrome 58 (58.0.3029.110)

  • detection
  • browser startup via james
  • proxy setup via james

Firefox 53 (53.0.3)

  • detection
  • browser startup via james
  • proxy setup via james

Opera 45 (45.0.2552.888)

  • detection
  • browser startup via james
  • proxy setup via james

Ubuntu (17.04)

screenshot from 2017-06-05 11-50-50

General unexpected behavior:

none

Chrome 58 (58.0.3029.110)

  • detection
  • browser startup via james
  • proxy setup via james

Firefox 53 (53.0.3)

  • detection
  • browser startup via james
  • proxy setup via james

Opera 45 (45.0.2552.888)

  • detection
  • browser startup via james
  • proxy setup via james

Conclusion

  • There are definitely some issues regarding detection
  • Startup works for all browser that got detected
  • Automatically setting up the proxy only works for chrome and firefox on all platforms
  • We should add a hint for the user that he might be required to manually setup the proxy connection
  • Windows needs some love

@nerdbeere
Copy link
Member Author

@mitchhentges what do you think? I don't think we have any regressions

@mitchhentges
Copy link
Member

I suppose that master is a development branch, and we aren't releasing right away. Go for it

@nerdbeere nerdbeere merged commit 81f5d9a into master Jun 6, 2017
@nerdbeere nerdbeere deleted the update-james-browser-launcher branch June 6, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants