Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: support docker-compose v2 + minor improvements #721

Merged
merged 3 commits into from
May 19, 2023

Conversation

jamaljsr
Copy link
Owner

Closes #719
Closes #614

Description

This PR adds support for Docker Compose v2 since v1 has officially been deprecated.

I also updated the compose file to give nodes more time to gracefully shutdown and added a name field to avoid the dirname of 1 being displayed in Docker Desktop.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (da5b45b) 100.00% compared to head (8426376) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #721   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          139       139           
  Lines         4305      4312    +7     
  Branches       780       780           
=========================================
+ Hits          4305      4312    +7     
Impacted Files Coverage Δ
src/lib/docker/nodeTemplates.ts 100.00% <ø> (ø)
src/lib/docker/composeFile.ts 100.00% <100.00%> (ø)
src/lib/docker/dockerService.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamaljsr jamaljsr changed the title docker: support docker-compose v2 + minore improvements docker: support docker-compose v2 + minor improvements May 19, 2023
@jamaljsr jamaljsr merged commit a1d4764 into master May 19, 2023
@jamaljsr jamaljsr deleted the docker-updates branch May 19, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Doesn't support docker compose v2 Bug: Lost Blocks in Bitcoin-d after unclean node restart
2 participants