Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bad buffer): mint asset metadata #672

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

amovfx
Copy link
Contributor

@amovfx amovfx commented Feb 13, 2023

Metadata needed to be a base64 string.
Should I write some tests for the asset info drawer?

Closes #(issue number goes here)

Description

Meta Data was being encoded wrong. This is fixed.

Steps to Test

  1. Mint an asset
  2. Add anything meta data field
  3. Open AssetInfoDrawer. You should see meta data at top

Screenshots

[Only if applicable]

Metadata needed to be a base64 string.
Copy link
Owner

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Looks good. Thanks for the fix.

@jamaljsr jamaljsr merged commit 832bd65 into jamaljsr:feat/add-taro Feb 15, 2023
jamaljsr pushed a commit that referenced this pull request May 16, 2023
Metadata needed to be a base64 string.

Co-authored-by: Andrew Oseen <amovfx@protonmail.com>
jamaljsr pushed a commit that referenced this pull request May 16, 2023
Metadata needed to be a base64 string.

Co-authored-by: Andrew Oseen <amovfx@protonmail.com>
jamaljsr pushed a commit that referenced this pull request May 16, 2023
Metadata needed to be a base64 string.

Co-authored-by: Andrew Oseen <amovfx@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants