Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(images): add support for Bitcoin Core v22.0 #510

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

cstenglein
Copy link
Contributor

This adds the already existing v22.0 from Docker Hub to the nodes.json & readme.

Still left v0.21.1 in there to have a "pre-taproot" version available.

@jamaljsr
Copy link
Owner

jamaljsr commented Nov 7, 2021

Thanks for the contribution. I did start working on this a while ago but got sidetracked and never circled back. I'll review this tomorrow. I think there may be more changes needed due to the new version not having two periods.

@cstenglein
Copy link
Contributor Author

Tests are running now locally.

I don't know about the compatibility of LND with bitcoind v22.0, so just I set the compatibility of everything 0.21.1 to 22.0 for now. If that's not correct, just tell me :)

@cstenglein
Copy link
Contributor Author

Tested it with yarn:dev:
worked and downloaded the image correctly.

@jamaljsr jamaljsr self-requested a review November 22, 2021 13:36
Copy link
Owner

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch locally and it works with all three LN implementations. I'm actually surprised this didn't require more changes to deal with the new version format. Apologies for taking so long to review, but thanks so much for the contribution. 👍

@jamaljsr jamaljsr merged commit a9e0f40 into jamaljsr:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants