Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right-click menus for nodes and channels #312

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented Mar 3, 2020

Description

This PR adds right-click context menus for nodes & channels to save a few clicks getting to the actions. This just surfaces the same actions that are available in each node's sidebar Actions tab. You can also right click on the backend connections to change the backend of an LN node.

Steps to Test

  1. Create a network and start it
  2. Right-click on the any node
  3. Confirm you can see the actions listed
  4. Click on one or more of them to confirm the correct action is triggered
  5. Open a channel
  6. Right-click on the channel
  7. Confirm you can see the "Close Channel" action listed

Screenshots

image

image

image

image

@codecov-io
Copy link

Codecov Report

Merging #312 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #312   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         105    108    +3     
  Lines        2465   2514   +49     
  Branches      400    423   +23     
=====================================
+ Hits         2465   2514   +49
Impacted Files Coverage Δ
src/components/designer/link/Backend.tsx 100% <ø> (ø) ⬆️
src/components/designer/bitcoind/ActionsTab.tsx 100% <ø> (ø) ⬆️
src/components/designer/lightning/ActionsTab.tsx 100% <ø> (ø) ⬆️
src/components/designer/link/Channel.tsx 100% <ø> (ø) ⬆️
.../designer/lightning/actions/OpenChannelButtons.tsx 100% <100%> (ø) ⬆️
src/components/common/AdvancedOptionsButton.tsx 100% <100%> (ø) ⬆️
src/components/common/RemoveNode.tsx 100% <100%> (ø)
...ents/designer/lightning/actions/PaymentButtons.tsx 100% <100%> (ø) ⬆️
src/components/designer/LinkContextMenu.tsx 100% <100%> (ø)
...rc/components/designer/link/CloseChannelButton.tsx 100% <100%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5b20c...6c0daef. Read the comment docs.

@jamaljsr jamaljsr merged commit b740361 into master Mar 3, 2020
@jamaljsr jamaljsr deleted the feat/context-menu branch March 3, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants