Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): fix corrupt redux state causing errors #305

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

jamaljsr
Copy link
Owner

Description

Fixes an issue where global state data from one network is leftover and used by another network. This causes some errors to be thrown when refreshing the network from all nodes.

Screenshots

image

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #305 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #305   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     95           
  Lines        2127   2144   +17     
  Branches      348    350    +2     
=====================================
+ Hits         2127   2144   +17
Impacted Files Coverage Δ
src/store/models/bitcoind.ts 100% <100%> (ø) ⬆️
src/components/home/NetworkCard.tsx 100% <100%> (ø) ⬆️
src/components/network/NetworkView.tsx 100% <100%> (ø) ⬆️
src/store/models/lightning.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c752e1...df1dbde. Read the comment docs.

@jamaljsr jamaljsr merged commit 95801a0 into master Feb 28, 2020
@jamaljsr jamaljsr deleted the fix/chart-error branch February 28, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants