Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments): add ability to create & pay invoices #254

Merged
merged 14 commits into from
Dec 9, 2019
Merged

Conversation

jamaljsr
Copy link
Owner

@jamaljsr jamaljsr commented Dec 8, 2019

Description

Adds the ability to create and pay invoices from within Polar. I only implemented the bare minimum fields required to create/pay in LND & c-lightning. More fields can easily be added in the future based on specific user requests.

This feature is helpful for those cases when you want to test one side of the transfer from your app. You won't need to use the terminal in Polar for the other side.

Steps to Test

  1. Boot up a network with 2 nodes
  2. Create a channel between alice & bob
  3. Click on bob, then the Actions tab
  4. Click the Create Invoice button, set the amount, then submit the form
  5. Click on the Copy & Close button
  6. Click on alice, then the Actions tab
  7. Click the Pay Invoice button, paste the invoice, then submit the form
  8. Confirm the channel updates with the balances adjusted

Screenshots

image

image

image

image

@codecov-io
Copy link

codecov-io commented Dec 8, 2019

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #254   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          77     80    +3     
  Lines        1421   1514   +93     
  Branches      226    237   +11     
=====================================
+ Hits         1421   1514   +93
Impacted Files Coverage Δ
...mponents/designer/lightning/actions/RemoveNode.tsx 100% <ø> (ø) ⬆️
src/components/terminal/OpenTerminalButton.tsx 100% <ø> (ø) ⬆️
.../components/designer/lightning/actions/Deposit.tsx 100% <ø> (ø) ⬆️
src/store/models/app.ts 100% <ø> (ø) ⬆️
src/components/designer/lightning/ActionsTab.tsx 100% <ø> (ø) ⬆️
.../designer/lightning/actions/OpenChannelButtons.tsx 100% <100%> (ø) ⬆️
src/lib/lightning/notImplementedService.ts 100% <100%> (ø) ⬆️
src/lib/lightning/lnd/lndProxyClient.ts 100% <100%> (ø) ⬆️
.../designer/lightning/actions/CreateInvoiceModal.tsx 100% <100%> (ø)
src/lib/lightning/clightning/clightningService.ts 100% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53a805...c582b44. Read the comment docs.

@jamaljsr jamaljsr merged commit def3084 into master Dec 9, 2019
@jamaljsr jamaljsr deleted the feat/payments branch December 9, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants